Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing /apps/files/img/computer.svg #45631

Closed
5 of 8 tasks
DerSaxxe opened this issue Jun 2, 2024 · 2 comments
Closed
5 of 8 tasks

[Bug]: Missing /apps/files/img/computer.svg #45631

DerSaxxe opened this issue Jun 2, 2024 · 2 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 29-feedback bug feature: files

Comments

@DerSaxxe
Copy link

DerSaxxe commented Jun 2, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

If you choose edit locally from text file of a shared link with the right to edit there is no icon.

Steps to reproduce

  1. Create a directory and a text file (.md) within it.
  2. Share this directory as link with the right to edit.
  3. Open the link and click at the three-dot-menu.
  4. Now you will see the missing icon for edit locally.

Expected behavior

There should be an icon (source html code says at /apps/files/img/computer.svg)

Installation method

Community Web installer on a VPS or web space

Nextcloud Server version

29

Operating system

Other

PHP engine version

PHP 8.3

Web server

Other

Database engine version

MySQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "cloud.REMOVED.de"
        ],
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "29.0.1.1",
        "overwrite.cli.url": "https:\/\/cloud.REMOVED.de\/",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbport": "",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "default_phone_region": "DE",
        "skeletondirectory": "",
        "default_language": "de",
        "force_language": "de",
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "tls",
        "mail_sendmailmode": "smtp",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauthtype": "LOGIN",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "auth.webauthn.enabled": false,
        "maintenance": false,
        "theme": "",
        "loglevel": 1,
        "maintenance_window_start": 1,
        "activity_expire_days": 7
    }
}

List of activated Apps

Enabled:
  - activity: 2.21.1
  - bruteforcesettings: 2.9.0
  - calendar: 4.7.4
  - cloud_federation_api: 1.12.0
  - comments: 1.19.0
  - contactsinteraction: 1.10.0
  - dav: 1.30.1
  - federatedfilesharing: 1.19.0
  - files: 2.1.0
  - files_downloadlimit: 2.0.0
  - files_pdfviewer: 2.10.0
  - files_reminders: 1.2.0
  - files_sharing: 1.21.0
  - files_trashbin: 1.19.0
  - files_versions: 1.22.0
  - logreader: 2.14.0
  - lookup_server_connector: 1.17.0
  - notifications: 2.17.0
  - oauth2: 1.17.0
  - password_policy: 1.19.0
  - photos: 2.5.0
  - privacy: 1.13.0
  - provisioning_api: 1.19.0
  - registration: 2.4.0
  - related_resources: 1.4.0
  - serverinfo: 1.19.0
  - settings: 1.12.0
  - survey_client: 1.17.0
  - systemtags: 1.19.0
  - text: 3.10.0
  - theming: 2.4.0
  - twofactor_backupcodes: 1.18.0
  - updatenotification: 1.19.1
  - user_status: 1.9.0
  - viewer: 2.3.0
  - workflowengine: 2.11.0
Disabled:
  - admin_audit: 1.19.0 (installed 1.19.0)
  - bookmarks: 14.1.1 (installed 14.1.1)
  - circles: 29.0.0-dev (installed 24.0.1)
  - dashboard: 7.9.0 (installed 7.9.0)
  - encryption: 2.17.0
  - federation: 1.19.0 (installed 1.19.0)
  - files_external: 1.21.0
  - firstrunwizard: 2.18.0 (installed 2.18.0)
  - nextcloud_announcements: 1.18.0 (installed 1.18.0)
  - recommendations: 2.1.0 (installed 2.1.0)
  - sharebymail: 1.19.0 (installed 1.19.0)
  - support: 1.12.0 (installed 1.12.0)
  - suspicious_login: 7.0.0
  - twofactor_totp: 11.0.0-dev
  - user_ldap: 1.20.0
  - weather_status: 1.9.0 (installed 1.9.0)

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

No response

Additional info

No response

@DerSaxxe DerSaxxe added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Jun 2, 2024
@joshtrichards joshtrichards added 1. to develop Accepted and waiting to be taken care of feature: files and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 3, 2024
@joshtrichards
Copy link
Member

I see we dropped the computer.svg in #39808, but it's still referenced here:

icon: function(filename, context) {
var locked = context.$file.data('locked');
if (!locked) {
return OC.imagePath('files', 'computer.svg')
}

Thanks for the report!

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2024

Fixed now, the edit locally was not supposed to be in link shares

@skjnldsv skjnldsv closed this as completed Aug 1, 2024
@skjnldsv skjnldsv self-assigned this Aug 1, 2024
@skjnldsv skjnldsv moved this to Done in Files to vue Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 29-feedback bug feature: files
Projects
Status: Done
Development

No branches or pull requests

4 participants