Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When changing file extension ask for confirmation #46528

Closed
T0mWz opened this issue Jul 15, 2024 · 8 comments · Fixed by #49308
Closed

When changing file extension ask for confirmation #46528

T0mWz opened this issue Jul 15, 2024 · 8 comments · Fixed by #49308
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. 🍀 2025-Spring
Milestone

Comments

@T0mWz
Copy link

T0mWz commented Jul 15, 2024

We sometimes see users changing a file name, unintentionally / unknowingly deleting the extension dot or removing the whole extension. After which they cannot open the document because it is no longer recognized as such, resulting in user confusion.

Where on an operating system is explicitly asked for confirmation when accidentally changing / deleting an extension.
Is there a possibility to check if there is still an extension present when editing, or else give a notification?

Example what an OS will ask you, by changing an extension.
remove_extension
change_extension

@T0mWz T0mWz added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jul 15, 2024
@joshtrichards joshtrichards changed the title [Feature request] When changing file extension ask for confirmation When changing file extension ask for confirmation Jul 15, 2024
@jancborchardt
Copy link
Member

Sounds reasonable and helpful indeed. @sorbaugh @AndyScherzinger @marcoambrosini for Files planning.

@jancborchardt jancborchardt moved this to 🧭 Planning evaluation / ideas in 🖍 Design team Sep 13, 2024
@AndyScherzinger
Copy link
Member

I'd agree, while @T0mWz mentioned the OS level. So yes, I think this seems reasonable in general and something you can catch on the client level, so (since we are in the server repo) it makes sense to catch this in the WebUI and is would likely also be easily doable for the Mobile apps, yet for Desktop OS we would need to rely on the OS either asking the user, or not asking the user. Screenshots are from MacOS, but I can't say how the different Linux distros or rather their Desktop/file manager handle such renames - Windows behaves the same way like MacOS.

So I would say web and Mobile should check if the file extensions (characters after the last dot changed) and if so launch an expicit confirmation screen with an explanation of the potential consequences as shown above.

@jancborchardt
Copy link
Member

Yup, that’s how I also understood, as a function of the web interface (and mobile, yup).

@joshtrichards joshtrichards added the hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. label Sep 13, 2024
@sorbaugh
Copy link
Contributor

This would be a really nice QoL improvement. We'll look into it.

@sorbaugh sorbaugh moved this to 📄 To do (~10 entries) in 📁 Files team Sep 26, 2024
@sorbaugh sorbaugh added this to the Nextcloud 31 milestone Sep 26, 2024
@marcoambrosini marcoambrosini moved this from 🧭 Planning evaluation / ideas to 📐 At design in 🖍 Design team Oct 2, 2024
@marcoambrosini marcoambrosini self-assigned this Oct 2, 2024
@marcoambrosini marcoambrosini moved this from 📐 At design to 🏗️ At engineering in 🖍 Design team Oct 2, 2024
@sorbaugh
Copy link
Contributor

This is a Frontend only task.

Some notes:

  • Also add a "don't ask me again" option
  • Add a config option
  • Add the Dialog (probably needs to be added to only 1 place)

Estimation: 3-5 days

@sorbaugh
Copy link
Contributor

Assigning @fenn-cs

@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Nov 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Nov 19, 2024
@marcoambrosini
Copy link
Member

Image

Looks great, will the don't ask again part be implemented? Or is it tracked somewhere else?

@marcoambrosini
Copy link
Member

Problem: It's currently impossible to rename a file, only to change its format. Don't know if this is related to the pr addressing this issue.

cc @sorbaugh @nfebe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files hotspot: filename handling Filenames - invalid, portable, blacklisting, etc. 🍀 2025-Spring
Projects
Status: ☑️ Done
Status: 🎉 Done
Development

Successfully merging a pull request may close this issue.

7 participants