Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Deleted files offer not-working "view-in-folder" action #47115

Closed
4 of 8 tasks
susnux opened this issue Aug 7, 2024 · 2 comments · Fixed by #49143
Closed
4 of 8 tasks

[Bug]: Deleted files offer not-working "view-in-folder" action #47115

susnux opened this issue Aug 7, 2024 · 2 comments · Fixed by #49143
Assignees
Milestone

Comments

@susnux
Copy link
Contributor

susnux commented Aug 7, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

The file actions for deleted files offer the file action "view in folder" but that action does not work, it will redirect to files where of course no file is visible.

Is it intended to be called "Show source folder" or similar? Or should it not be shown at all?

image

Steps to reproduce

  1. upload a file
  2. delete the file
  3. go to trash bin
  4. click file actions

Expected behavior

Either name it "Show source folder" or do not show it at all.

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

cc @skjnldsv

@susnux susnux added bug 1. to develop Accepted and waiting to be taken care of feature: files labels Aug 7, 2024
@susnux susnux added this to the Nextcloud 30 milestone Aug 7, 2024
@github-project-automation github-project-automation bot moved this to Legacy bugs in Files to vue Aug 7, 2024
@susnux susnux moved this from Legacy bugs to Potential regressions in Files to vue Aug 7, 2024
@susnux susnux removed this from 📁 Files team Aug 7, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Aug 8, 2024

It's a mistake, it should not be shown at all
It means the conditions are wrongly defined

enabled(nodes: Node[], view: View) {
// Only works outside of the main files view
if (view.id === 'files') {
return false
}
// Only works on single node
if (nodes.length !== 1) {
return false
}
const node = nodes[0]
if (!node.isDavRessource) {
return false
}
if (node.permissions === Permission.NONE) {
return false
}
return node.type === FileType.File
},

@skjnldsv
Copy link
Member

skjnldsv commented Aug 8, 2024

We should check that the source is indeed at the root of the user folder too

@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@skjnldsv skjnldsv self-assigned this Nov 8, 2024
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Nov 8, 2024
@github-project-automation github-project-automation bot moved this from Potential regressions to Done in Files to vue Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants