Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation for php.ini mistake in nc 12 beta 2 #4838

Closed
jospoortvliet opened this issue May 12, 2017 · 9 comments · Fixed by #5014
Closed

Recommendation for php.ini mistake in nc 12 beta 2 #4838

jospoortvliet opened this issue May 12, 2017 · 9 comments · Fixed by #5014

Comments

@jospoortvliet
Copy link
Member

The admin screen warns about unoptimized php settings, but the first value mentioned seems broken:
php_value opcache.enable=on
That should, I believe, be:
php_value opcache.enable=1

This is Nextcloud 12 Beta 2.

See:
screenshot_20170509_124940

@ghost
Copy link

ghost commented May 12, 2017

yes: nextcloud/documentation#450
Do i get a t-shirt please?!?
i would really really appreciate: need XL-shirt

@MorrisJobke
Copy link
Member

php_value opcache.enable=on

I did this by intention. I set it to 1 on PHP 5.6 and 7.0. In one of them the opcache was not activated. With on it worked fine. Even if the PHP documentation says something different I would stick to that, because I ran into issues with 1 which was fixed with the on.

@MorrisJobke
Copy link
Member

That should, I believe, be:

Never believe and always test ;)

@ghost
Copy link

ghost commented May 12, 2017

1

is working properly for php 7.1.
i maintain a lot of server running with that value as i wrote here and on my blog.
additionally on shared server hosted by all-inkl.com and 1&1.

...:::carsten

@MorrisJobke
Copy link
Member

i maintain a lot of server running with that value as i wrote here and on my blog.
additionally on shared server hosted by all-inkl.com and 1&1.

Is this always PHP 7.1 and PHP 7.0 or also older PHP?

@ghost
Copy link

ghost commented May 12, 2017

PHP 7 and 7.1
I do not have an environment < PHP7 anymore. So to be honest - i cannot state.

@MorrisJobke
Copy link
Member

I do not have an environment < PHP7 anymore. So to be honest - i cannot state.

Okay ... let me try to find one and test this again.

@JSoko
Copy link
Member

JSoko commented May 21, 2017

the (wrong) hint with opcache.enable=on persists in NC12RC4...

@MorrisJobke
Copy link
Member

MorrisJobke commented May 21, 2017

Fix is in #5014 and #5015

@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone May 22, 2017
@MorrisJobke MorrisJobke removed their assignment May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants