Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enh] : Complete design requirements for sharing sidebar split #50375

Open
6 tasks
nfebe opened this issue Jan 23, 2025 · 3 comments
Open
6 tasks

[Enh] : Complete design requirements for sharing sidebar split #50375

nfebe opened this issue Jan 23, 2025 · 3 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Comments

@nfebe
Copy link
Contributor

nfebe commented Jan 23, 2025

Left over on non-blocking reviews from : #50282

pending from original design requirements:

  • Limit list length to 3 shares and "show all" (to show all shares)

from @marcoambrosini

  • Copy internal link should go into the multi-select as an always visible option
  • Share link component should show a button if no links are present as per the mockup, but below the input field

from @nfebe

  • Backend API should not handle detection of share type? (for example with mail share, in sharinginput)
  • "Search for share recipients" looks off should probably "visually hide for accessibility"

@nfebe nfebe added enhancement feature: sharing ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 23, 2025
@nfebe nfebe self-assigned this Jan 23, 2025
@nfebe
Copy link
Contributor Author

nfebe commented Jan 23, 2025

Design requirements: #48925

@nfebe nfebe changed the title enh : Complete design requirements for sharing sidebar split [Enh] : Complete design requirements for sharing sidebar split Jan 23, 2025
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Jan 28, 2025
@nfebe
Copy link
Contributor Author

nfebe commented Jan 31, 2025

When the share info is too lengthy the line should have line breaks, but it seems to be a single line info, you you face a horizontal scrollbar (info line right below the tab headers - Andy

Image
  • Done

@provokateurin
Copy link
Member

I also noticed that you still get search results with local users when searching in the external share section.

@susnux susnux moved this to 🏗️ In progress in 📁 Files team Mar 14, 2025
@susnux susnux added the 1. to develop Accepted and waiting to be taken care of label Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement feature: sharing ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
Status: 🏗️ In progress
Status: 🏗️ At engineering
Development

No branches or pull requests

4 participants