[Bug]: loglevel setting does not work on 31.0.0-RC1

[paulijar]

⚠️ This issue respects the following points: ⚠️

• This is a bug, not a question or a configuration/webserver/proxy issue.
• This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
• Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
• I agree to follow Nextcloud's Code of Conduct.

Bug description

The logging system does not seem to respect the loglevel configured in config.php or through the admin settings, instead the level is always warning (2). Testing with value 0 in the configuration, I saw some selected few debug messages appear in the log but most of them were missing.

I believe that the bug is in the commit 63f3309. Without understanding the entire Log module or the context of the said fix, I'm pretty sure that there should be statement $this->nestingLevel--; in front of this return statement, too:

server/lib/private/Log.php

Line 274 in fba7ef9

return min((int)$configLogLevel, ILogger::FATAL);

Or at least adding this line fixed the issue on my system. This also showcases nicely, why it is usually a bad idea to have multiple return statements in a non-trivial function.

Steps to reproduce

1. Configure loglevel as 0
2. Use your Nextcloud for a while
3. Check logs => there are only few debug level lines
4. Configure loglevel as 4
5. Use your Nextcloud for a while
6. Check logs => there probably are some warning level lines after the point in time when the configuration was changed

Expected behavior

The loglevel configuration should be respected by the logging system.

Nextcloud Server version

31

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

• Default user-backend (database)
• LDAP/ Active Directory
• SSO - SAML
• Other

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

No response

[nickvergessen]

Noticed this too the other day.

Without understanding the entire Log module or the context of the said fix, I'm pretty sure that there should be statement $this->nestingLevel--; in front of this return statement, too:

Totally true and one of the reasons why I disliked the approach, but I had no better idea yet :(