Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show checkbox where the favorite star is now #6361

Closed
MorrisJobke opened this issue Sep 4, 2017 · 6 comments · Fixed by #6709
Closed

Show checkbox where the favorite star is now #6361

MorrisJobke opened this issue Sep 4, 2017 · 6 comments · Fixed by #6709
Assignees
Labels
design Design, UI, UX, etc. enhancement
Milestone

Comments

@MorrisJobke
Copy link
Member

As discussed at the conf:

  • show the checkbox for selecting an element where currently the star icon is
  • add a little star indicator at the top right of the mime type/thumbnail (as on Android and iOS)
  • add the "Favourite" action to the three dots menu

cc @nextcloud/designers

@danxuliu @ChristophWurst Does one of you want to look into this?

@MorrisJobke MorrisJobke added design Design, UI, UX, etc. enhancement labels Sep 4, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone Sep 4, 2017
@danxuliu danxuliu self-assigned this Sep 11, 2017
@danxuliu
Copy link
Member

I will take care of this in the next days.

@jancborchardt
Copy link
Member

An important addition is that the filetype icon / preview should then also be part of the clickable area to open the file / folder.

@danxuliu let me know when there’s something to review. :)

@jancborchardt jancborchardt changed the title Show checkbox where the favourite star is now Show checkbox where the favorite star is now Sep 22, 2017
@danxuliu
Copy link
Member

@jancborchardt I have started to implement this but as you can imagine there are several approaches for the CSS that would work. So any preference with respect to floats, absolute positions and things like that? Although probably someone else with good CSS knowledge will have to clean up my mess anyway :-P

An important addition is that the filetype icon / preview should then also be part of the clickable area to open the file / folder.

I assume that the star indicator would not be clickable given that the Favourite action will be now in the three dots menu, right? Otherwise making the star indicator clickable and at the same time using the filetype icon / preview to open the file / folder would be very error prone.

@skjnldsv
Copy link
Member

@danxuliu, I will help with css. Do everything you can. I will take a look at it! 👍 😉

@danxuliu
Copy link
Member

I will help with css. Do everything you can. I will take a look at it! 👍 😉

Thanks a lot! :-) I will ping you in the next days ;-)

@jancborchardt
Copy link
Member

I assume that the star indicator would not be clickable given that the Favourite action will be now in the three dots menu, right?

Exactly, the favorite star would only be an indicator, not clickable. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants