-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show checkbox where the favorite star is now #6361
Comments
I will take care of this in the next days. |
An important addition is that the filetype icon / preview should then also be part of the clickable area to open the file / folder. @danxuliu let me know when there’s something to review. :) |
@jancborchardt I have started to implement this but as you can imagine there are several approaches for the CSS that would work. So any preference with respect to floats, absolute positions and things like that? Although probably someone else with good CSS knowledge will have to clean up my mess anyway :-P
I assume that the star indicator would not be clickable given that the Favourite action will be now in the three dots menu, right? Otherwise making the star indicator clickable and at the same time using the filetype icon / preview to open the file / folder would be very error prone. |
@danxuliu, I will help with css. Do everything you can. I will take a look at it! 👍 😉 |
Thanks a lot! :-) I will ping you in the next days ;-) |
Exactly, the favorite star would only be an indicator, not clickable. :) |
As discussed at the conf:
cc @nextcloud/designers
@danxuliu @ChristophWurst Does one of you want to look into this?
The text was updated successfully, but these errors were encountered: