Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position of Gallery-button and inconsistent behavior on hover #7374

Closed
MariusBluem opened this issue Dec 3, 2017 · 5 comments
Closed

Position of Gallery-button and inconsistent behavior on hover #7374

MariusBluem opened this issue Dec 3, 2017 · 5 comments
Assignees
@skjnldsv
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. high regression
Milestone
Nextcloud 13

Comments

@MariusBluem
Copy link
Member

Safari-version: 11.0.1
Nextcloud-version: 13.0 beta1

dez -03-2017 16-39-12
@MariusBluem MariusBluem added 1. to develop Accepted and waiting to be taken care of bug design Design, UI, UX, etc. labels Dec 3, 2017
@MariusBluem MariusBluem added this to the Nextcloud 13 milestone Dec 3, 2017
@MorrisJobke
Copy link
Member

cc @nextcloud/designers @oparoz

@jancborchardt
Copy link
Member

@skjnldsv that #gallery-button needs to be on the far right. Previously that was done via float: right as you can see from gallery/css/gallerybutton.css. How would we do that now with flexbox and the path? The button should definitely not be inthe left cause it interferes with the Add button.

@pixelipo
Copy link
Contributor

It should be done with margin-left:auto, but the problem is that it's always renderer before the Add button.
I think this requires rethinking the JS method responsible for painting the gallery-button

@skjnldsv skjnldsv self-assigned this Dec 12, 2017
@skjnldsv
Copy link
Member

I'll take a look if you want @pixelipo

@skjnldsv skjnldsv mentioned this issue Dec 13, 2017
Merged
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Dec 13, 2017
@skjnldsv
Copy link
Member

Please review :) nextcloud/gallery#336 & #7478

@nextcloud-bot nextcloud-bot mentioned this issue Jul 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. high regression
Projects
None yet
Milestone
Nextcloud 13
Development

No branches or pull requests
5 participants
@MorrisJobke @jancborchardt @pixelipo @skjnldsv @MariusBluem