Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user mentions in comments #753

Closed
3 of 7 tasks
blizzz opened this issue Aug 5, 2016 · 4 comments
Closed
3 of 7 tasks

user mentions in comments #753

blizzz opened this issue Aug 5, 2016 · 4 comments

Comments

@blizzz
Copy link
Member

blizzz commented Aug 5, 2016

I see it split in those sub tasks:

  • 1. After posting a comment containing a valid username prepended by an @ (@foobar) the user (if existing & having access to the file) gets a notification about a comment where he is mentioned. This does not happen when editing comments. (This was worked on in [WIP] notify user when mentioned in comments owncloud/core#24495)
    PR at Notifications for simple @-mentioning in comments #1449
  • 2. When presenting the comment, the client should replace the username with the corresponding display name. The web UI should do this at first. In edit mode, the @username format is used (for now).
    PR at comment mentions: show displayname not uid #1738
  • 3. When writing or editing a comment and typing an @ in the beginning of a word followed by another character an auto-complete is offered. It only includes users that have access to the file. Results are supposed to show up with a slight delay. For scaling reasons, it needs to be figured out whether all possible users are fetched in the background in advance, or on demand (like search dialog).
  • 4. The comments API is extended so that the Comment instance also offers a list of username-displayname combinations for the users mentioned in it. The list is empty, if not user is mentioned. This allows the client to replace the @username without looking up display names at the ownCloud server in seperate steps. I.e. the WebDAV resource returns this information just as well.
    PR at comment mentions: show displayname not uid #1738

Further desired additions, might be out of scope for this stage:

@blizzz
Copy link
Member Author

blizzz commented Sep 19, 2016

PR implementing the first part: #1449

@blizzz
Copy link
Member Author

blizzz commented Sep 19, 2016

After talking to @LukasReschke, a subscription model would be totally fancy as well, so that notifications will happen on subsequent comments, without the need to mention users again. A step 5.

@MorrisJobke
Copy link
Member

@blizzz Could I ask you to create a ticket for 12 that sums up what is left here? Thanks :)

@blizzz
Copy link
Member Author

blizzz commented Dec 1, 2016

@MorrisJobke here we go: #2443

Closing this one here therefore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants