Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page doen't get themed #835

Closed
juliusknorr opened this issue Aug 11, 2016 · 4 comments
Closed

Update page doen't get themed #835

juliusknorr opened this issue Aug 11, 2016 · 4 comments
Labels
feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@juliusknorr
Copy link
Member

We need to load the theming app css file in the update routine.

Somewhere here:

server/lib/base.php

Lines 377 to 378 in fa352a8

$oldTheme = $systemConfig->getValue('theme');
$systemConfig->setValue('theme', '');

@juliusknorr juliusknorr added good first issue Small tasks with clear documentation about how and in which place you need to fix things in. 1. to develop Accepted and waiting to be taken care of feature: theming labels Aug 11, 2016
@rullzer
Copy link
Member

rullzer commented Sep 4, 2016

Do we really want this?

IMO the updating should be as simple as possible. Enough can go wrong already and I don't think we need theming to mess with that.

@juliusknorr
Copy link
Member Author

It would be nice to have, but I think you are right, as loading the theming app and generating the css stuff might have too much potential of breaking something.

@nickvergessen
Copy link
Member

I agree with @rullzer apps are not loaded in the update for a reason.

@LukasReschke
Copy link
Member

Closing due to 💣 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: theming good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

5 participants