-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update page doen't get themed #835
Labels
feature: theming
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
Comments
juliusknorr
added
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
1. to develop
Accepted and waiting to be taken care of
feature: theming
labels
Aug 11, 2016
10 tasks
Do we really want this? IMO the updating should be as simple as possible. Enough can go wrong already and I don't think we need theming to mess with that. |
It would be nice to have, but I think you are right, as loading the theming app and generating the css stuff might have too much potential of breaking something. |
I agree with @rullzer apps are not loaded in the update for a reason. |
Closing due to 💣 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature: theming
good first issue
Small tasks with clear documentation about how and in which place you need to fix things in.
We need to load the theming app css file in the update routine.
Somewhere here:
server/lib/base.php
Lines 377 to 378 in fa352a8
The text was updated successfully, but these errors were encountered: