Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments with mentions look broken in the comments view #9273

Closed
nickvergessen opened this issue Apr 23, 2018 · 4 comments
Closed

Comments with mentions look broken in the comments view #9273

nickvergessen opened this issue Apr 23, 2018 · 4 comments

Comments

@nickvergessen
Copy link
Member

Activity view

bildschirmfoto von 2018-04-23 12-33-43

Comments view

bildschirmfoto von 2018-04-23 12-33-47

It seems to be broken, because the author information row uses the same CSS classes as the inline mentions. (width 100%, etc.), see Nextcloud 13 for help how it should look

cc @nextcloud/designers

@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Apr 23, 2018
@danxuliu
Copy link
Member

Avatars are going to be removed from mentions in comments (and then I guess that we should remove them from the activity view too) so that should implicitly fix this issue.

@nickvergessen
Copy link
Member Author

Okay, so let's keep this issue, to make sure this gets addressed before we release something.

@jancborchardt
Copy link
Member

Looking at the Riot redesign, the avatars in mentions look pretty great:

Sorry for picking this up again @nextcloud/designers (especially @pixelipo ;) but it seems we just need to find the right adjustment – like with putting a container with slight grey background around the avatar and name – and then it looks great.

@nextcloud-bot nextcloud-bot added the stale Ticket or PR with no recent activity label Jun 30, 2018
@MorrisJobke
Copy link
Member

Fixed by #10288

bildschirmfoto 2018-07-25 um 14 32 01

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants