Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contacts menu doesn't find / list all users (with external user backend webdav) #9505

Closed
violoncelloCH opened this issue May 17, 2018 · 10 comments
Labels
1. to develop Accepted and waiting to be taken care of bug feature: contacts menu

Comments

@violoncelloCH
Copy link
Member

Steps to reproduce

  1. create several users and groups with users from external user backend (webdav)
  2. go to contacts menu
  3. there is only one user listed (I think i created bevor updating nextcloud from 13 to 13.0.2

Expected behaviour

all users should be listed or at least the should pop up when searching for

Actual behaviour

only one user (+local users) is listed
this one was probably created before upgrading nextcloud to 13.0.2

Server configuration

Operating system: Ubuntu 16.04

Web server: apache2

Database: mariaDB

PHP version: 7.2

Nextcloud version: 13.0.2

Updated from an older Nextcloud/ownCloud or fresh install: fresh (updated from 13.0.0)

Where did you install Nextcloud from: official nextcloud.com download

Signing status:

Signing status
No errors have been found.

List of activated apps:

App list
Enabled:
  - activity: 2.6.1
  - admin_notifications: 1.0.1
  - bruteforcesettings: 1.0.3
  - comments: 1.3.0
  - dav: 1.4.6
  - federatedfilesharing: 1.3.1
  - federation: 1.3.0
  - files: 1.8.0
  - files_automatedtagging: 1.3.0
  - files_external: 1.4.1
  - files_pdfviewer: 1.2.1
  - files_rightclick: 0.8.4
  - files_sharing: 1.5.0
  - files_texteditor: 2.5.1
  - files_trashbin: 1.3.0
  - files_versions: 1.6.0
  - files_videoplayer: 1.2.0
  - firstrunwizard: 2.2.1
  - gallery: 18.0.0
  - groupfolders: 1.2.0
  - logreader: 2.0.0
  - lookup_server_connector: 1.1.0
  - metadata: 0.6.0
  - nextcloud_announcements: 1.2.0
  - notifications: 2.1.2
  - oauth2: 1.1.0
  - password_policy: 1.3.0
  - provisioning_api: 1.3.0
  - quota_warning: 1.2.0
  - ransomware_protection: 1.1.0
  - serverinfo: 1.3.0
  - sharebymail: 1.3.0
  - survey_client: 1.1.0
  - systemtags: 1.3.0
  - theming: 1.4.1
  - twofactor_backupcodes: 1.2.3
  - updatenotification: 1.3.0
  - user_external: 0.4
  - workflowengine: 1.3.0
Disabled:
  - admin_audit
  - encryption
  - files_accesscontrol
  - user_ldap```
</details>

**Nextcloud configuration:**
<details>
<summary>Config report</summary>

{
"system": {
"instanceid": "REMOVED SENSITIVE VALUE",
"passwordsalt": "REMOVED SENSITIVE VALUE",
"secret": "REMOVED SENSITIVE VALUE",
"trusted_domains": [
"REMOVED SENSITIVE VALUE"
],
"auth.bruteforce.protection.enabled": true,
"0": [
".htaccess",
"Thumbs.db",
"thumbs.db"
],
"cron_log": true,
"activity_expire_days": 33,
"datadirectory": "REMOVED SENSITIVE VALUE",
"overwrite.cli.url": "REMOVED SENSITIVE VALUE",
"dbtype": "mysql",
"version": "13.0.2.1",
"dbname": "REMOVED SENSITIVE VALUE",
"dbhost": "REMOVED SENSITIVE VALUE",
"dbport": "",
"dbtableprefix": "oc_",
"mysql.utf8mb4": true,
"dbuser": "REMOVED SENSITIVE VALUE",
"dbpassword": "REMOVED SENSITIVE VALUE",
"installed": true,
"enable_previews": true,
"enabledPreviewProviders": [
"OC\Preview\PNG",
"OC\Preview\JPEG",
"OC\Preview\GIF",
"OC\Preview\BMP",
"OC\Preview\XBitmap",
"OC\Preview\Movie",
"OC\Preview\PDF",
"OC\Preview\MP3",
"OC\Preview\TXT",
"OC\Preview\MarkDown"
],
"preview_max_x": 1024,
"preview_max_y": 768,
"preview_max_scale_factor": 1,
"filesystem_check_changes": 0,
"filelocking.enabled": "true",
"htaccess.RewriteBase": "/",
"integrity.check.disabled": false,
"knowledgebaseenabled": false,
"logfile": "/var/nc_data/nextcloud.log",
"loglevel": 0,
"logtimezone": "Europe/Berlin",
"log_rotate_size": 104857600,
"maintenance": false,
"memcache.local": "\OC\Memcache\APCu",
"memcache.locking": "\OC\Memcache\Redis",
"overwriteprotocol": "https",
"redis": {
"host": "REMOVED SENSITIVE VALUE",
"password": "REMOVED SENSITIVE VALUE",
"port": 0,
"timeout": 0
},
"quota_include_external_storage": false,
"share_folder": "",
"skeletondirectory": "/srv/nextclouddata/presets/",
"theme": "",
"trashbin_retention_obligation": "auto, 7",
"updater.release.channel": "stable",
"mail_smtpmode": "smtp",
"mail_smtpauthtype": "LOGIN",
"user_backends": [
{
"class": "\OCA\User_External\WebDAVAuth",
"arguments": [
"REMOVED SENSITIVE VALUE"
]
}
],
"mail_from_address": "REMOVED SENSITIVE VALUE",
"mail_domain": "REMOVED SENSITIVE VALUE",
"mail_smtpauth": 1,
"mail_smtpport": "465",
"mail_smtpname": "REMOVED SENSITIVE VALUE",
"mail_smtppassword": "REMOVED SENSITIVE VALUE",
"mail_smtpsecure": "ssl",
"mail_smtphost": "REMOVED SENSITIVE VALUE"
}
}

</details>

**Are you using external storage, if yes which one:** webdav

**Are you using encryption:** no

**Are you using an external user-backend, if yes which one:** Webdav

### Client configuration
**Browser:** Firefox 59 / Chrome

**Operating system:** Win 10

### Logs
#### Web server error log
<details>
<summary>Web server error log</summary>

Insert your webserver log here

</details>

#### Nextcloud log (data/nextcloud.log)
<details>
<summary>Nextcloud log</summary>

Insert your Nextcloud log here

</details>

#### Browser log
<details>
<summary>Browser log</summary>

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

</details>
@MorrisJobke
Copy link
Member

cc @georgehrke @ChristophWurst

@ChristophWurst
Copy link
Member

What user back-end is that? Is that an external app?

@violoncelloCH
Copy link
Member Author

@ChristophWurst it's the official External User Support App (https://github.com/nextcloud/apps/tree/master/user_external) configured to authenticate against a WebDAV server

@ChristophWurst
Copy link
Member

Okay, so I think the issue is that the contacts menu uses the \OCP\Contacts\IManager to search contacts, which in turn only operates on registered address books. Looking at our code base shows me that the only address books we're registering are the ones from the DAV app: https://github.com/nextcloud/server/blob/master/apps/dav/lib/CardDAV/ContactsManager.php.

@georgehrke @MorrisJobke @rullzer does anybody know if the DAV address books should contain those external users as well?

cc @skjnldsv because I think you asked about a similar issue last week.

@violoncelloCH
Copy link
Member Author

I also recognized the contacts menu doesn't show the profile picture/avatar for the shown contacts from external user backend; but the ones of database users are shown

@ChristophWurst
Copy link
Member

I also recognized the contacts menu doesn't show the profile picture/avatar for the shown contacts from external user backend; but the ones of database users are shown

IIRC that's because the avatars are a feature of the internal DAV representation of system users. We haven't got any information about external users, I think.

@violoncelloCH
Copy link
Member Author

But users of external storage have got profile pics or avatars whith a color and a letter in the admin user view and in the sharing dialog... why are the images shown in these locations and not in the contacts menu?

@ChristophWurst
Copy link
Member

Fair enough. Then those features must use a different API or it's not stored in the PHOTO index the contacts menu reads from:

if (isset($contact['PHOTO']) && strpos($contact['PHOTO'], $avatarPrefix) === 0) {

@violoncelloCH
Copy link
Member Author

this issue should stay open as it is not yet fixed....

@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Jul 30, 2018
@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Jul 30, 2018
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Jul 30, 2018
@rullzer rullzer removed this from the Nextcloud 16 milestone Apr 2, 2019
@szaimen
Copy link
Contributor

szaimen commented May 20, 2021

I am going to close this since there doesn't seem to be a lot of interest (no upvotes) and no respond since over 2 years. Please reopen if you still want to implement this.

@szaimen szaimen closed this as completed May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug feature: contacts menu
Projects
None yet
Development

No branches or pull requests

7 participants