Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to a chat from the root page has a UI glitch if sidebar was open before #12747

Closed
ShGKme opened this issue Jul 18, 2024 · 3 comments · Fixed by nextcloud-libraries/nextcloud-vue#5833

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Jul 18, 2024

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

before

On sidebar appearing, there is a weird effect with unexpected margin change which moves navigation to the left and then back.

In slow-mo you can see that actually it moves back and forward:

slow

❗ **the glitch speed is defined by NcAppSidebar transition. It is no <NcAppnavigation>'s transition.

Comes after @nextcloud/vue v8.13.0 from nextcloud-libraries/nextcloud-vue#5608

🤯 However, that change is probably not the source of the issue. Glitch depends on an action in NcAppNavigation.


It is not reproducible if <LeftSidebar> is hidden and an empty <NcAppNavigation> added in Talk.

<NcAppNavigation />
<NcAppContent>
	<!-- move somewhere because it is required -->
	<LeftSidebar v-if="getUserId && !isFullscreen" ref="leftSidebar" v-show="false" />
	<router-view />
</NcAppContent>

no-left-sidebar


It is reproducible if the main part is removed, <RightSidebar> is replaced with an empty <NcAppSidebar> without new open feature.

<LeftSidebar ref="leftSidebar" />
<NcAppContent>
	<!-- <router-view />-->
</NcAppContent>
<!-- <RightSidebar :is-in-call="isInCall" />-->
<NcAppSidebar v-if="token" />

only-left-sidebar

@ShGKme ShGKme self-assigned this Jul 18, 2024
@ShGKme ShGKme changed the title Initial load of root page has a UI glitch if sidebar was open before Switching to a chat from the root root page has a UI glitch if sidebar was open before Jul 18, 2024
@ShGKme ShGKme moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 💬 Talk team Jul 18, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 💬 Talk team Jul 18, 2024
@ShGKme ShGKme changed the title Switching to a chat from the root root page has a UI glitch if sidebar was open before Switching to a chat from the root page has a UI glitch if sidebar was open before Jul 18, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 18, 2024

Gifs are from Talk Desktop, but everything is the same in Web

@ShGKme

This comment was marked as outdated.

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 18, 2024

Found a problem in @nextcloud/vue

NcContent is scrollable (overflow: hidden only removes the scroll bar unlike overflow: clip) and during open scrolled to the focused element in the sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging a pull request may close this issue.

1 participant