Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recording consent property is inconsistent #13085

Closed
SystemKeeper opened this issue Aug 22, 2024 · 2 comments · Fixed by #13135
Closed

Recording consent property is inconsistent #13085

SystemKeeper opened this issue Aug 22, 2024 · 2 comments · Fixed by #13135

Comments

@SystemKeeper
Copy link
Contributor

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

API on room level should only return 0/1, but seems to be able to also return 2.

Talk app

Talk app version: 20 RC2

@SystemKeeper
Copy link
Contributor Author

| `recordingConsent` | int | v4 | | Whether recording consent is required before joining a call (see [constants list](constants.md#recording-consent-required)) (only available with `recording-consent` capability) |
might need change then to not refer to the consent constants?

@nickvergessen
Copy link
Member

It's properly documented in OpenAPI docs:

* @param int $recordingConsent New consent setting for the conversation
* (Only {@see RecordingService::CONSENT_REQUIRED_NO} and {@see RecordingService::CONSENT_REQUIRED_YES} are allowed here.)

Will adjust the other docs too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants