Breadcrumb menu is misaligned on share links

[tribut]

Steps to reproduce

1. Upgrade to NC 17.0
2. Share a link to a folder
3. Observe breadcrumb menu

Expected behaviour

Menu should be aligned to top, not overlaying header from files app. Grid view toggle should also be aligned to breadcrumb and scroll.

Actual behaviour

This is a regression from 16.0.4.

Server configuration

Operating system: Debian stretch
Web server: Apache 2.4
Database: MariaDB
PHP version: 7.2
Nextcloud version: 17.0
Updated from an older Nextcloud/ownCloud or fresh install: Upgraded from 16.0.4
Where did you install Nextcloud from: Tarball
Signing status:

Signing status

No errors have been found.

List of activated apps:

App list

Enabled:
  - accessibility: 1.3.0
  - activity: 2.10.1
  - apporder: 0.7.1
  - bruteforcesettings: 1.4.0
  - calendar: 1.7.1
  - cloud_federation_api: 1.0.0
  - comments: 1.7.0
  - contacts: 3.1.4
  - dav: 1.13.0
  - federatedfilesharing: 1.7.0
  - federation: 1.7.0
  - files: 1.12.0
  - files_pdfviewer: 1.6.0
  - files_rightclick: 0.15.1
  - files_sharing: 1.9.0
  - files_trashbin: 1.7.0
  - files_versions: 1.10.0
  - files_videoplayer: 1.6.0
  - firstrunwizard: 2.6.0
  - gallery: 18.4.0
  - logreader: 2.2.0
  - lookup_server_connector: 1.5.0
  - music: 0.10.1
  - nextcloud_announcements: 1.6.0
  - notes: 3.0.3
  - notifications: 2.5.0
  - oauth2: 1.5.0
  - password_policy: 1.7.0
  - previewgenerator: 2.1.0
  - privacy: 1.1.0
  - provisioning_api: 1.7.0
  - recommendations: 0.5.0
  - richdocuments: 3.4.2
  - serverinfo: 1.7.0
  - sharebymail: 1.7.0
  - spreed: 7.0.0
  - support: 1.0.1
  - survey_client: 1.5.0
  - systemtags: 1.7.0
  - tasks: 0.11.3
  - text: 1.1.0
  - theming: 1.8.0
  - twofactor_backupcodes: 1.6.0
  - twofactor_nextcloud_notification: 2.1.1
  - twofactor_totp: 4.0.0
  - updatenotification: 1.7.0
  - viewer: 1.1.0
  - workflowengine: 1.7.0
Disabled:
  - admin_audit
  - encryption
  - files_external
  - user_ldap

Nextcloud configuration:

Config report

{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "version": "17.0.0.9",
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbtableprefix": "oc_",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "forcessl": true,
        "forceSSLforSubdomains": true,
        "config_is_read_only": false,
        "memcache.local": "\\OC\\Memcache\\APCu",
        "log_type": "syslog",
        "loglevel": 2,
        "appstoreenabled": true,
        "mail_smtpmode": "smtp",
        "theme": "",
        "maintenance": false,
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trashbin_retention_obligation": "auto",
        "asset-pipeline.enabled": false,
        "assetdirectory": "***REMOVED SENSITIVE VALUE***",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "htaccess.RewriteBase": "\/",
        "mail_smtpauthtype": "LOGIN",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "preview_max_filesize_image": 50,
        "preview_max_x": 16384,
        "preview_max_y": 16384,
        "simpleSignUpLink.shown": false,
        "mysql.utf8mb4": true
    }
}

Are you using external storage, if yes which one: no
Are you using encryption: no
Are you using an external user-backend, if yes which one: no

Client configuration

Browser: FF 69
Operating system: Ubuntu

Logs

n/a

[kesselb]

cc @skjnldsv @GretaD

[GretaD]

hey @tribut, can you please check if this problem still exist, I cannot reproduce it anymore. Also I notice that in the screenshot you sent, there's no 'download all' button. Please when you test it, check if the button also will show up

[tribut]

Hey @GretaD, thanks for checking. Have you tried with NC 17.0? As far as I see this is still the latest release. All the apps are up-to-date according to the Apps page in NC.

Here is a link to an example gallery: https://wolke.tribut.de/s/Yyn8DCY4AEy2yxr

The "Download all" button is there, but it moves to the overflow menu once the screen width crosses a certain threshold.

[GretaD]

this is a very interesting bug (not in a good way :P ) Yes, you're right, it actually happens also on 18th version. I am going to investigate a bit more and push a PR when I find out what is happening. When i test it locally on my dev env, both versions are ok :/

[danxuliu]

The issue is a regression introduced by the Talk sidebar in public share pages feature added in Talk 7, so I will transfer this to the Talk repository :-)

In order to add the sidebar the default layout is modified, but this modification is applied even when the sidebar is not visible, and unfortunately it breaks the layout with shared folders :-(

It is related to the issue with the toolbar in Text, although in the case of shared folders the best solution might be not to load the Talk sidebar at all.

[danxuliu]

This was fixed in #2340, and therefore in Talk 7.0.2, which was released today :-) (but please note that you also need Nextcloud 17.0.1!)