Add option for disable chat in public shares

[Ivansss]

Related with #2280
Apart from the global options in #2283, it would be nice to have an option to disable chat in public shares for a specific file.
This option will be available only for the file owner and enabled by default.
If the file owner disables this option, only internal users/shares will be able to use the chat attached to this file and the chat will not appear in public shares.

@nickvergessen
@nextcloud/designers ideas?

[jancborchardt]

Since it is related to how you share, the option needs to be in the menu of the Share link instead:
nextcloud/server#12178

With the mockup by @juliushaertl on hiding the advanced settings, we can put it in there. :)

[Ivansss]

@jancborchardt we thought about adding it to the "share link" menu too :)
But the problem is that the chat is not share related but file related.
In other words, there is just one chat per file, not one chat per share.
That way, all the sharees use the same chat for collaboration.
So this option should be outside of the "share link" menu.

[danxuliu]

It could still be added to the Sharing tab outside all shares, but I think that it will be strange.

But there was an additional reason to add it to the Chat tab, which is not touching the server code for this. As far as I know right now apps can not extend the Sharing tab, so the option would need to be added in the server itself, and I would like to avoid as much as possible to add app specific code to the server (yes, the Password protect by Talk option is hardcoded in the server, but in that case there was no other way around it ;-) ).

Also, another phrasing (which I think is better) that we came up for the option was Enable public conversations (instead of Enable chat in public shares).

[Ivansss]

Also, another phrasing (which I think is better) that we came up for the option was Enable public conversations (instead of Enable chat in public shares).

I know that we came up with "Enable public conversations" 😄 , but then I thought that this wording might be hard to relate with the chat shown in public shares.

Another idea could be "Enable chat in shared links"? So we use a similar term as in Files.

[nickvergessen]

@jancborchardt

With the mockup by juliushaertl on hiding the advanced settings, we can put it in there

I think it is somewhat weird to have it in there, if it manages all shares for the same file. And I can almost guarantee that there will be a request to manage them individually and that will be a pain to oversight and manage in the backends...

[jancborchardt]

I think it is somewhat weird to have it in there, if it manages all shares for the same file.

No, the menu exists for every share link individually, including mail shares (and we could even have it in the shares with people on the same instance).

So you could e.g. send a link to one group which makes the chat visible and actionable, and to another who only sees the file itself.

@Ivansss And yes, it should simply be called "Enable chat". Links are not "public" per se, so we should not call it that or people think it will be made public on some list. ;)

[nickvergessen]

The share table has no support for this, so it will become a mess. Exactly why I think we should stick to the global setting for now. The details for this minor change is just too much effort at the moment

[jancborchardt]

@ma12-co @jenniferpiperek do you understand this, and/or do you have a proposal here? :)

[marcoambrosini]

I think it's reasonable to have a global setting for this. Per share setting would be Ideal for the current UI, since this would be the only global setting from what I see. Do we have any other global (per shared file and not per share) setting?

As per the busy popover, I think we could also explore a horizontal navigation flow similar to the color picker one, something like:

[tigernero79]

I saw that talk 7.0.1 update was released which should include the ability to disable chat in the URL of the file sharing but I can't find how to do it is the option?

[nickvergessen]

I saw that talk 7.0.1 update was released which should include the ability to disable chat in the URL of the file sharing but I can't find how to do it is the option?

It's in the admin settings, visit index.php/settings/admin/talk on your instance as an admin

[tigernero79]

thanks, but option came out only with such 7.0.2