-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turnserver compatibility user/password instead static-auth #3301
Comments
User/Pass is used in the end. The Talk app creates the username and password. |
When you look into the Settings for Talk, you van enter the turnserver URL and the shared-secret. |
@fancycode maybe you can help to clarify this? |
Username/password for the TURN configuration are valid indefinitely and should only be on a per-user base (see #84 on the initial implementation). As the global TURN credentials are sent to each participant in a call (registered and anonymous), everybody could (ab-)use the credentials to create other connections through the TURN server from other services. That's why Talk switched to the shared secret TURN configuration and hands out short-lived credentials to users that can not be used indefinitely. If we allow configuring TURN username/password in the admin settings, it should show a big warning that the credentials will be sent to all participants and therefore must be considered "public". Another option would be to add this to the personal settings similar to what was done in #84 but fallback to the global shared secret setting if a user doesn't configure his own credentials. |
Okay, sounds like it is not a good idea, but only to get other turns to work. So not a priority at the moment. |
It is the same as with the shared secret. Using username:password of a turnserver user is exactly valid as it is with the currently used static-auth. |
No the current approach is that every users get's unique custom credentials which expire, while with the fixed static auth, I can copy your turn credentials and server url to my instance after I had a guest call on yours, and then abuse your turn server for my talk calls? |
Topic can be closed as it is not relevant. |
With the current implementation, I did not find any ability to use the login procedure with the turnserver (coTurn, ...) In Talk config mask, only the static-auth is possible, which is actually not a good procedure.
Request: User/pass for the talk setup should be allowed.
Describe alternatives you've considered
N/A
The text was updated successfully, but these errors were encountered: