Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachment gets re-uploaded if you close/open the talk tab #3904

Closed
skjnldsv opened this issue Jul 14, 2020 · 2 comments · Fixed by #4550
Closed

Attachment gets re-uploaded if you close/open the talk tab #3904

skjnldsv opened this issue Jul 14, 2020 · 2 comments · Fixed by #4550
Assignees
@marcoambrosini
Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings good first issue medium
Milestone
v10.0.0-beta.1

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Jul 14, 2020 •
edited by nickvergessen
Loading

Steps to reproduce

  1. Send a local image.jpg to a room x
  2. Change to room y
  3. Close tab
  4. Re-open tab

Expected behaviour

The room y loads

Actual behaviour

The room y loads and upload the image.jpg again to room y
I guess this is because the input[type=file] doesn't get reset after upload, and it gets populated again when you reopen the page as it's considered as a form. cc @ma12-co

Talk app

Talk app version: 9.0.1
Custom Signaling server configured: no idea (company cloud)

Custom TURN server configured: no idea (company cloud)

Custom STUN server configured: no idea (company cloud)
@skjnldsv skjnldsv changed the title Attachment gets reupload if you close/open the talk tab Attachment gets re-uploaded if you close/open the talk tab Jul 14, 2020
@skjnldsv
Copy link
Member Author

spreed/src/components/NewMessageForm/NewMessageForm.vue

Line 301 in 99d8be7

processFiles(files, this.token, uploadId)

https://github.com/nextcloud/contacts/blob/b47082b0baf162be7647399276432054856b7716/src/components/ContactDetails/ContactDetailsAvatar.vue#L213-L217

@nickvergessen nickvergessen added this to the 💚 Next Major (20) milestone Jul 14, 2020
@nickvergessen
Copy link
Member

Seems fixed since #3988

@nickvergessen nickvergessen added feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings labels Aug 19, 2020
@skjnldsv skjnldsv reopened this Nov 6, 2020
@skjnldsv skjnldsv mentioned this issue Nov 6, 2020
Merged
@skjnldsv skjnldsv linked a pull request Nov 6, 2020 that will close this issue
Fix uploading same file twice in a row in Chromium #4550
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcoambrosini marcoambrosini

Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings good first issue medium
Projects
None yet
Milestone
v10.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

Fix uploading same file twice in a row in Chromium nextcloud/spreed
3 participants
@nickvergessen @skjnldsv @marcoambrosini