Dashboard widget should show the actual mention message

[jancborchardt]

Currently, the Dashboard widget only shows "You were mentioned" which is a bit low on info (especially because notifications show more of the message). The subline should show the actual message which mentions you so you can get some more info before clicking.

Conversation list	Widget

[nickvergessen]

This is not possible with the current api.
Also what should happen on multiple mentions?

[jancborchardt]

This is not possible with the current api.

Yup, that’s what I understood, just opening here so we don’t forget about it. What would need to be changed where to make it work? In Talk I assume, not in Dashboard?

Also what should happen on multiple mentions?

To keep it similar to what happens in the subline of the conversation list: The most recent mention would be shown shown.

[nickvergessen]

Then we can reuse the stored last mention id, and basically need to adjust the API to optionally load that comment instead of the last message id when getting the rooms. However since we at that point don't know if we will have a match for a mention or call, we wouldn't load the last message for the half empty content message. So I guess we would need to run 2 requests in that case, or we totally bloat up the API response and always return both.

[ChristophWurst]

As a user I would also prefer if You were mentioned would only be used for direct mentions and not @all.

[nickvergessen]

With #10250 this turned into a backend task.

The subline is created in

spreed/lib/Dashboard/TalkWidget.php

Lines 178 to 205 in e116b34

	if ($lastMessage instanceof IComment) {
	$message = $this->messageParser->createMessage($room, $participant, $room->getLastMessage(), $this->l10n);
	$this->messageParser->parseMessage($message);
	$now = $this->timeFactory->getDateTime();
	$expireDate = $message->getComment()->getExpireDate();
	if ((!$expireDate instanceof \DateTime || $expireDate >= $now)
	&& $message->getVisibility()) {
	$placeholders = $replacements = [];
	foreach ($message->getMessageParameters() as $placeholder => $parameter) {
	$placeholders[] = '{' . $placeholder . '}';
	if ($parameter['type'] === 'user' || $parameter['type'] === 'guest') {
	$replacements[] = '@' . $parameter['name'];
	} else {
	$replacements[] = $parameter['name'];
	}
	}
	$subtitle = str_replace($placeholders, $replacements, $message->getMessage());
	}
	}
	if ($room->getCallFlag() !== Participant::FLAG_DISCONNECTED) {
	$subtitle = $this->l10n->t('Call in progress');
	} elseif ($participant->getAttendee()->getLastMentionMessage() > $participant->getAttendee()->getLastReadMessage()) {
	$subtitle = $this->l10n->t('You were mentioned');
	}

As mentioned above we simply can use the "last mentioned id" and start rendering that message instead of the "last message"