Chat in sidebar doesn't update correctly

[schiessle]

Not sure if this is a Talk issue or more a general server/sidebar issue. Feel free to move it to another repository.

When I open a file which is not yet shared and go to the chat tab I see this:

Now I click on "share file" which lead me to the share dialog, I share the file and go back to the chat tab.

I would now expect that I can start chatting directly, but I still see the same as on the screenshot above. Only after closing the sidebar and opening it again I can start chatting. The chat tab should update automatically, either triggered by the share operation or by switching back to the chat tab.

[PVince81]

Confirmed as this has annoyed me as well.

Need to see after #4291 is merged as it integrates with modified/new APIs from the files app. If that bit is not enough, might need extra handling.

[danxuliu]

The bug is in the Files app, and it is caused by the FileInfo object not being properly updated after a file is shared. You can see that too in the Files app itself; after a file is shared the Shared text is not shown for that file in the file list until the list is reloaded.

It is a regression introduced in Nextcloud 18 if I recall correctly, when the sharing tab was moved to Vue.

[nickvergessen]

It is a regression introduced in Nextcloud 18

No, this bug is there since ages, more like ownCloud times

[danxuliu]

It is a regression introduced in Nextcloud 18

No, this bug is there since ages, more like ownCloud times

No, it is a regression introduced in Nextcloud 18. In Nextcloud 17 the FileInfo object is properly updated when a file is shared, so the Shared text is immediately shown for that file in the file list without having to reload. And as the FileInfo object is properly updated with Talk 7 the Share this file / Join this conversation button in the Chat tab of the Files app sidebar works as expected.

[nickvergessen]

Never the less it's something that needs fixing in Server? Is it already fixed with the new sidebar thingy?

[danxuliu]

Never the less it's something that needs fixing in Server?

Yes.

Is it already fixed with the new sidebar thingy?

No :-(

[nickvergessen]

So closing here.