Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirection when opening the sidebar for another file without leaving previous call first #4570

Closed
danxuliu opened this issue Nov 9, 2020 · 2 comments
Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents low regression
Milestone

Comments

@danxuliu
Copy link
Member

danxuliu commented Nov 9, 2020

This is a regression introduced in Talk 9 with the handling of conflicts between sessions (note that this is different from #4243, which is a legit, albeit unexpected, redirection).

Note that the redirection does not happen if, instead of opening the sidebar in another shared file, it is opened in an unshared file or a folder.

With the external signaling server there is no redirection, but in this case the media is not properly stopped. That is a different bug, though.

How to test

  • Use the internal signaling server
  • Open the Files app
  • Share two files
  • Refresh (due to the bug in the Files app that causes the FileInfo to not be updated)
  • Open the sidebar for the first shared file
  • Open the Chat tab
  • Join the conversation
  • Start a call
  • Open the sidebar for the second shared file (without leaving the call first)

Expected result

Nothing strange happens.

Actual result

The browser redirects to the main Talk UI.

@PVince81
Copy link
Member

Not sure if worth fixing.

When I worked on the redirections and did some tests I noticed that when we're outside the Talk UI, the redirections to "not found" or "duplicate session" were still happening.

Now for duplication session, there's upcoming work to allow those, so this ticket will likely be obsoleted once #1587 is closed.

@nickvergessen nickvergessen modified the milestones: v11.3.0, 💕 Next Minor (21.1) Jun 11, 2021
@nickvergessen nickvergessen modified the milestones: 💕 Next Minor (21.1), 💙 Next Major (22), v12.0.0-rc.1, 💙 Next Patch (22) Jun 25, 2021
@nickvergessen
Copy link
Member

Actual result

The browser redirects to the main Talk UI.

Does not happen anymore. Instead you simply leave the call now with Files2Vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug feature: frontend 🖌️ "Web UI" client feature: talk-sidebar ⬅️ Sidebar integration of Talk into other apps like sharing and documents low regression
Projects
None yet
Development

No branches or pull requests

3 participants