Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstract away the MediaPlayer logic in ChatActivity to MediaPlayerManager #4563

Open
rapterjet2004 opened this issue Dec 20, 2024 · 0 comments
Open

Abstract away the MediaPlayer logic in ChatActivity to MediaPlayerManager #4563

rapterjet2004 opened this issue Dec 20, 2024 · 0 comments
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request

Comments

@rapterjet2004
Copy link
Contributor

Will likely require rewriting the MediaPlayerManager to be compatible with the more complicated functionality in ChatActivity (cycling through messages, marking messages as played, generating waveforms etc). I think a state machine (with an exposed enum) and some callbacks to observe should do the trick.

Will be helpful for eventually removing ChatKit, and replacing it with a full compose solution. The more functionality handled outside of ChatActivity the better.
@rapterjet2004 rapterjet2004 added 1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of (should be only set by nextcloud employees) enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rapterjet2004