Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add full-featured replacement or use original @nextcloud/dialogs #12

Closed
ShGKme opened this issue Feb 6, 2023 · 1 comment · Fixed by #407
Closed

Add full-featured replacement or use original @nextcloud/dialogs #12

ShGKme opened this issue Feb 6, 2023 · 1 comment · Fixed by #407
Assignees
@ShGKme
Labels
enhancement New feature or request low

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Feb 6, 2023

The current replacement for @nextcloud/dialogs is a boring native modal dialog.
@ShGKme ShGKme self-assigned this Feb 6, 2023
@ShGKme ShGKme mentioned this issue Feb 7, 2023
Closed
@ShGKme ShGKme added the enhancement New feature or request label Feb 7, 2023
@nickvergessen
Copy link
Member

the thing is dialogs will be more and more in the future bringing in the file picker and more things. So I guess using the original might be preferred, while we might want to overwrite the toast mechanism with a toast that is then outside of the client?

@ShGKme ShGKme added the low label Mar 1, 2023
@ShGKme ShGKme mentioned this issue Nov 10, 2023
Merged
@ShGKme ShGKme mentioned this issue Nov 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShGKme ShGKme

Labels
enhancement New feature or request low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(patchers): update OC.dialogs replacement with NcDialog-based adapter nextcloud/talk-desktop
2 participants
@nickvergessen @ShGKme