You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Please use the 👍 reaction to show that you are affected by the same issue.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.
Steps to reproduce
Login in Talk Desktop
Update Talk on the server, update Talk settings on the server
Get Nextcloud Talk was updated, you need to reload the page message
Reload the page
Or
Login in Talk Desktop and close the client
Update Talk on the server, update Talk settings on the server
Open the desktop client
Expected behavior
Talk Desktop has new settings (capabilities) and other server data.
Actual behavior
Talk Desktop has values that were stored after the login.
In the first scenario, reload doesn't help.
In the second scenario, after the application restart, it even doesn't know, that AppData is not valid.
Talk has x-nextcloud-talk-hash header. But currently, it is not correct in Talk Desktop. Its initial
value is set on the first conversations list load while Talk Desktop stores capabilities in AppData from
login.
Proposals
Re-request AppData on application start
The app loading is longer.
Not correct according to Nextcloud Talk was updated, you need to reload the page message. Should restart the application instead of reloading or changing the message.
Re-request AppData on UI load
The page loading is longer every time, including new windows and some error handling.
Store x-nextcloud-talk-hash in AppData and re-request on dirty hash
Store x-nextcloud-talk-hash in AppData, including the dirty flag
Request to restart or reload the page on a dirty hash
On page/app load check if hash is dirty and re-request only when dirty.
The text was updated successfully, but these errors were encountered:
Store x-nextcloud-talk-hash in AppData and re-request on dirty hash
This is what we should do. When a feature is enabled/disabled during the day you don't want to have people complaining that it still shows and doesn't work, just because they would need to manually reload/restart the app.
This is what we should do. When a feature is enabled/disabled during the day you don't want to have people complaining that it still shows and doesn't work, just because they would need to manually reload/restart the app.
I'm not sure, I understand you correct (or you understood me :D)
The main purpose of storing the hash is to not block app/window loading with requests each time, but only when it is known to be outdated.
It still requires manual update. Capabilities update without reload is not supported by Talk. Force reload may cause data loss (e.g. messages drafts).
How to use GitHub
Steps to reproduce
Nextcloud Talk was updated, you need to reload the page
messageOr
Expected behavior
Talk Desktop has new settings (capabilities) and other server data.
Actual behavior
Talk Desktop has values that were stored after the login.
In the first scenario, reload doesn't help.
In the second scenario, after the application restart, it even doesn't know, that AppData is not valid.
Talk has
x-nextcloud-talk-hash
header. But currently, it is not correct in Talk Desktop. Its initialvalue is set on the first conversations list load while Talk Desktop stores capabilities in AppData from
login.
Proposals
Re-request AppData on application start
The app loading is longer.
Not correct according to
Nextcloud Talk was updated, you need to reload the page
message. Should restart the application instead of reloading or changing the message.Re-request AppData on UI load
The page loading is longer every time, including new windows and some error handling.
Store
x-nextcloud-talk-hash
in AppData and re-request on dirty hashx-nextcloud-talk-hash
in AppData, including the dirty flagThe text was updated successfully, but these errors were encountered: