Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linking local files without ?fileID does not work #2774

Open
mstyp opened this issue Aug 2, 2022 · 6 comments
Open

linking local files without ?fileID does not work #2774

mstyp opened this issue Aug 2, 2022 · 6 comments
Labels

Comments

@mstyp
Copy link

mstyp commented Aug 2, 2022

Describe the bug

Linking to local files without the file ID does not work. EG, if I where to use gedit to edit the markdown file and reupload it to nextcloud, this:

[hurp](durp.md?fileId=123)

would work, but this:

[hurp](durp.md)

does not work. this is a problem since I do a lot of local editing of files with markor when I don't have a connection to the server.

To Reproduce
Steps to reproduce the behavior:

  1. highlight text in the nextcloud editer
  2. create a link to local file in the same directory
  3. highlight text again
  4. click "edit link",
  5. remove ?fileId=123 part of url
  6. click link again, a new tab opens but its to "https://durp.md/'.
  7. download file, edit in gedit
  8. see that raw text is wrong. fix so its [hurp](durp.md)
  9. reupload
  10. go to nextcloud. try to click link. opens new tab to blank page.

Expected behavior
click link, new tab opens to correct file.

Client details:

  • OS: debian 11
  • Browser: firefox esr
  • Nextcloud version: 23.0.4 - 23.0.4.1
  • Device: desktop
Server details

Text app version: (3.4.1

Operating system:

debian 11

Web server:
Apache/2.4.53 (Debian) (fpm-fcgi)
Database:
mysql 10.5.15
PHP version:
8
Nextcloud version: (see Nextcloud admin page)
23.0.4 - 23.0.4.1

Logs

Nextcloud log (data/nextcloud.log)

to diffuclt to redact

Browser log

dont know how to find

@mstyp mstyp added the bug Something isn't working label Aug 2, 2022
@vinicius73
Copy link
Member

vinicius73 commented Aug 17, 2022

@marcelklehr
Copy link
Member

Confirmed.

@marningmol
Copy link

I'm happy to see this marked as high priority.

I'd like to add a user story of just how vital this is.

I've been championing a switch to Nextcloud at our studio. I thought I had tested markdown capabilities by checking that a document rendered properly, including relative image embeds. Since this worked perfectly, it did not occur to me that normal links could somehow not work.

Right now we're trying to decide whether to give up our migration or go through all our links to insert file ids and ruin the workflow of those that use external editors.

I believe this feature is greatly needed, and hope the team can find time to address it quickly.

@mejo-
Copy link
Member

mejo- commented May 11, 2023

Dear @marningmol and @mstyp did you consider to try out the Nextcloud Collectives app? There, links to pages without fileId parameter are supposed to work.

@mstyp
Copy link
Author

mstyp commented May 15, 2023

No, the collectives app does not properly open links without without fileId. Have you tried it yourself? Select some text in collectives, click the "insert link" button, select "link to local file or foulder", pick the file you want to link to (say, test.md in the same directory). Click it and see that it works

But then go to edit the link (select text, then look up to "update link") and then remove the ?fileId=12345. When you try to click the link then, it thinks you are trying to go to https://test.md lol.

Even if it did work, I'm not going to stick all my documents into collectives. Its just not the right tool for that.

@joshtrichards
Copy link
Member

Related: #2136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🧭 Planning evaluation (don't pick)
Development

No branches or pull requests

7 participants