Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callout box with type info changes color with theme #4161

Closed
mejo- opened this issue May 9, 2023 · 3 comments · Fixed by #4301
Closed

Callout box with type info changes color with theme #4161

mejo- opened this issue May 9, 2023 · 3 comments · Fixed by #4301
Assignees
@max-nextcloud
Labels
1. to develop bug Something isn't working ux

Comments

@mejo-
Copy link
Member

mejo- commented May 9, 2023 •
edited
Loading

Describe the bug
The border color of callout boxes with type info currently is set to var(--color-primary-element). This variable can be changed in custom themes.

Instead, we should probably hardcode it to #006aa3 for now and use var(--color-info) once it got introduced.

See nextcloud-libraries/nextcloud-vue#4063 (comment).
@mejo- mejo- added bug Something isn't working 1. to develop ux labels May 9, 2023
@mejo- mejo- mentioned this issue May 9, 2023
Merged
@mejo-
Copy link
Member Author

mejo- commented May 12, 2023

nextcloud/server#38205 introduces var(--color-info). Once it got merged, we could switch to it but should still set #006aa3 as fallback for backwards-compatibility.

@max-nextcloud
Copy link
Collaborator

I'd be tempted to just migrate to using Nextcloud vues note card and not backport this.

But maybe that's two steps indeed. A fix with a hard coded default that can be backported and then the migration.

@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jun 16, 2023
@juliusknorr juliusknorr removed the status in 📝 Office team Jun 16, 2023
@juliusknorr juliusknorr moved this to 📄 To do (~10 entries) in 📝 Office team Jun 16, 2023
@max-nextcloud max-nextcloud mentioned this issue Jun 16, 2023
Closed
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Jun 16, 2023 •
edited
Loading

We are using Nextcloud vue 7 since stable25. So maybe we could move to using the component right away to fix this and backport all the way to stable25 with minor version bumps of Nextcloud vue.

update: the addition in Nextcloud vue still requires Nextcloud 27. So that is not an option.

@max-nextcloud max-nextcloud self-assigned this Jun 16, 2023
@max-nextcloud max-nextcloud mentioned this issue Jun 16, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@max-nextcloud max-nextcloud

Labels
1. to develop bug Something isn't working ux
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(css): info callout box color to --color-info nextcloud/text
2 participants
@mejo- @max-nextcloud