Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document status notice with connection issues is not sticky #4483

Closed
mejo- opened this issue Jul 11, 2023 · 3 comments
Closed

Document status notice with connection issues is not sticky #4483

mejo- opened this issue Jul 11, 2023 · 3 comments
Assignees
@enjeck
Labels
bug Something isn't working

Comments

@mejo-
Copy link
Member

mejo- commented Jul 11, 2023

Describe the bug
The document status notice that displays connection issues is not sticky anymore.

See #4474 (comment) for a screenshot.

To Reproduce
Steps to reproduce the behavior:

  1. Open a Text document with content long enough to scroll.
  2. Open network tab of browser developer tools, block network.
  3. Type something, see the notice about connection issues pop up.
  4. See that the notice is not sticky.
@mejo- mejo- added bug Something isn't working bug: regression labels Jul 11, 2023
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jul 11, 2023
@mejo- mejo- mentioned this issue Jul 11, 2023
Merged
7 tasks
@juliusknorr juliusknorr mentioned this issue Jan 17, 2024
Closed
@juliusknorr
Copy link
Member

Recording from #5100

Peek 2023-12-07 12-43

@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Jan 18, 2024
@juliusknorr
Copy link
Member

Once at it one could also address #4905

A possible fix needs careful testing of different ways that the text editor is embedded in scroll containers:

  • Single file opened in the viewer as a logged in user
  • Open a file on a public share link of that file
  • Open a file on a publich share link of a folder
    • Make sure to test this with Talk enabled and disabled as talk registers a sidebar on the public share pages
  • Collectives regular page and share links
  • Notes

@enjeck enjeck mentioned this issue Jan 30, 2024
Closed
9 tasks
@enjeck
Copy link
Contributor

enjeck commented Mar 22, 2024

Already fixed at 59e6bf5

@enjeck enjeck closed this as completed Mar 22, 2024
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📝 Office team Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@enjeck enjeck

Labels
bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliusknorr @mejo- @enjeck