Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BITV]: focus will be set on actions as far document will be saved #5326

Closed
JuliaKirschenheuter opened this issue Jan 31, 2024 · 4 comments · Fixed by #5327
Closed

[BITV]: focus will be set on actions as far document will be saved #5326

JuliaKirschenheuter opened this issue Jan 31, 2024 · 4 comments · Fixed by #5327
Assignees
@juliusknorr
Labels
a11y28checked needed for a11y accessibility bug Something isn't working

Comments

@JuliaKirschenheuter
Copy link
Contributor

The problem is: even if the focus has been set on some NcActions button (like in a sidebar or avatar), after few seconds focus will be moved to one specific NcActions button on the top right. My assuming is that this happens when file will be saved:

Peek 2024-01-31 15-02
@JuliaKirschenheuter JuliaKirschenheuter added bug Something isn't working accessibility labels Jan 31, 2024
@juliusknorr
Copy link
Member

Seems to be an issue also with other viewer file types:

Not sure where this goes wrong then exactly

Screen.Recording.2024-01-31.at.15.39.36.mov

@juliusknorr
Copy link
Member

Bumping @nextcloud/vue on server helps there is just a bit of flickering

@juliusknorr juliusknorr mentioned this issue Jan 31, 2024
Merged
1 task
@juliusknorr juliusknorr self-assigned this Jan 31, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jan 31, 2024
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 🏗️ In progress in 📝 Office team Jan 31, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Feb 1, 2024
@szaimen
Copy link
Contributor

szaimen commented Feb 2, 2024

the focus trap doesnt seem to work here:

Aufzeichnung.2024-02-02.134424.mp4

@szaimen szaimen reopened this Feb 2, 2024
@JuliaKirschenheuter
Copy link
Contributor Author

JuliaKirschenheuter commented Feb 2, 2024 •
edited
Loading

the focus trap doesnt seem to work here:

should be fixed via nextcloud-libraries/nextcloud-vue#4953, waiting for NcVue version v8.6.0 in stable28

Moving in Parked for now

@szaimen szaimen closed this as completed Feb 8, 2024
@szaimen szaimen added the a11y28checked needed for a11y label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliusknorr juliusknorr

Labels
a11y28checked needed for a11y accessibility bug Something isn't working
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Only unpause focus traps that we paused ourselves nextcloud/text
3 participants
@juliusknorr @JuliaKirschenheuter @szaimen