Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(placeholder): Show placeholder on empty paragraph, improve wording #6413

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix(placeholder): Show placeholder on empty paragraph, improve wording #6413

merged 1 commit into from
Sep 17, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 17, 2024

Fixes: #4619

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits

@mejo-
fix(placeholder): Show placeholder on empty paragraph, improve wording
d332a2b 
Fixes: #4619

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- added bug Something isn't working design Experience, interaction, interface, … 3. to review labels Sep 17, 2024
@mejo- mejo- self-assigned this Sep 17, 2024
marcoambrosini
marcoambrosini approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@juliushaertl juliushaertl merged commit 85fc0b0 into main Sep 17, 2024
59 of 61 checks passed
@juliushaertl juliushaertl deleted the fix/enhance_placeholder branch September 17, 2024 23:11
@mejo-
Copy link
Member Author

mejo- commented Sep 18, 2024

/backport to stable30

@backportbot backportbot bot mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

Assignees

@mejo- mejo-

Labels
3. to review bug Something isn't working design Experience, interaction, interface, …
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make placeholder more useful
3 participants
@mejo- @juliushaertl @marcoambrosini