Merge pull request #557 from nextcloud/backport/556/stable29

[stable29] fix: Correctly check result of function

Author: nickvergessen

index.php

@@ -708,12 +708,12 @@ public function verifyIntegrity(): void {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');

lib/Updater.php

@@ -670,12 +670,12 @@ public function verifyIntegrity(): void {
 -----END CERTIFICATE-----
 EOF;
 
-		$validSignature = (bool)openssl_verify(
+		$validSignature = openssl_verify(
 			file_get_contents($this->getDownloadedFilePath()),
 			base64_decode($response['signature']),
 			$certificate,
 			OPENSSL_ALGO_SHA512
-		);
+		) === 1;
 
 		if ($validSignature === false) {
 			throw new \Exception('Signature of update is not valid');