Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with NC21 #171

Closed
Glandos opened this issue Feb 23, 2021 · 12 comments
Closed

Compatibility with NC21 #171

Glandos opened this issue Feb 23, 2021 · 12 comments
Labels
0. Needs triage enhancement New feature or request

Comments

@Glandos
Copy link
Contributor

Glandos commented Feb 23, 2021

Is your feature request related to a problem? Please describe.
Nextcloud 21 is released. Could we set max version to 21 to make it work? Or is there anything that we can do?

@Glandos Glandos added 0. Needs triage enhancement New feature or request labels Feb 23, 2021
@Glandos
Copy link
Contributor Author

Glandos commented Feb 23, 2021

After clearing the cache and setting max version to 21, it seems to work perfectly for IMAP.

@violoncelloCH
Copy link
Member

Please note that there were some breaking changes introduced in NC 21 which affect the user_external app (#165). So I can't recommend updating to NC21 yet if you rely on user_external.

After clearing the cache and setting max version to 21, it seems to work perfectly for IMAP.

Interesting to hear that it seems to work for you. Did you try logging in with a new user?

@Glandos
Copy link
Contributor Author

Glandos commented Feb 23, 2021

No, I am a single user on this instance, sorry

@miqros
Copy link

miqros commented Feb 24, 2021

After clearing the cache and setting max version to 21, it seems to work perfectly for IMAP.

Hi. Could you please tell us, what exactly you did for get app working?

@2xsaiko
Copy link

2xsaiko commented Feb 26, 2021

It seems to work for me too. After the initial update I couldn't log back in with my external user, then I enabled the user_external app through the web interface (which also didn't seem to work), then disabled and re-enabled it via these commands:

occ app:disable user_external
occ app:enable user_external

Not sure why that got it to work, but I'll take it.

@cscognamiglio
Copy link

cscognamiglio commented Feb 28, 2021

I just had this issue because I (hastily) upgraded to NextCloud 21. I am using docker.
I solved by changing max-version in appinfo/info.xml to 21 like so:

<nextcloud min-version="17" max-version="21" />

I am using the http base authentication and it seems to work, my instance has several users, so I am not sure if this will be enough also for the other types of authentication.

@brknkfr
Copy link

brknkfr commented Mar 18, 2021

This pull request seems to fix it: #173

@jrd
Copy link

jrd commented Mar 28, 2021

The patch in the merge request works.

@almereyda
Copy link

Did you try the patch on an existing installation, or on a new one?

I can confirm that it works for the first case, but am unsure if the way it is implemented respects migrations for what they are.

Would you have any second opinions on my comment in the PR #173 (comment) ?

@jrd
Copy link

jrd commented Apr 6, 2021

I tried on a new one.

@brknkfr
Copy link

brknkfr commented Apr 6, 2021

Did you try the patch on an existing installation, or on a new one?

I tried on a fresh/new installation and on an old one.

@violoncelloCH
Copy link
Member

new release is out!
thanks for the PR @hlnd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

8 participants