Use IEventDispatcher in GroupManager.php

[bdovaz]

GroupManager currently relies on a private and deprecated API:

user_saml/lib/GroupManager.php

Line 145 in af8911c

$this->groupManager->emit('\OC\Group', 'preDelete', [$group]);

We should use the IEventDispatcher pattern as Nextcloud does in its IGroupManager implementation:

https://github.com/nextcloud/server/blob/5a6e48e85034aa81862b1fcbd93cb4ce58165e72/lib/private/Group/Manager.php#L287

Events:

https://github.com/nextcloud/server/tree/5a6e48e85034aa81862b1fcbd93cb4ce58165e72/lib/public/Group/Events

This interface exists since version 17.

If we don't want to be a breaking change, as seen in the example above, it sends it both ways (with PublicEmitter and IEventDispatcher).

@blizzz would you accept a PR?

[blizzz]

GroupManager currently relies on a private and deprecated API:

user_saml/lib/GroupManager.php

Line 145 in af8911c

$this->groupManager->emit('\OC\Group', 'preDelete', [$group]);

We should use the IEventDispatcher pattern as Nextcloud does in its IGroupManager implementation:

https://github.com/nextcloud/server/blob/5a6e48e85034aa81862b1fcbd93cb4ce58165e72/lib/private/Group/Manager.php#L287

Events:

https://github.com/nextcloud/server/tree/5a6e48e85034aa81862b1fcbd93cb4ce58165e72/lib/public/Group/Events

This interface exists since version 17.

If we don't want to be a breaking change, as seen in the example above, it sends it both ways (with PublicEmitter and IEventDispatcher).

@blizzz would you accept a PR?

Hey @bdovaz and thanks for the investigation.

It might be that those old events are listened to in server and thrown again properly – but it does not seem to be the case here. So yes, I would gladly accept a PR.

We can have both methods in 6.2.x and drop the legacy once bumping to 6.3 or 7. I do not see usage of the old event atm, and as you say the interface exists for ages, so it'd consider it okay for a minor bump. We can keep an issue open for that case.

[blizzz]

On a second though, #690 qualifies for a minor bump, but so replacing would be just fine.