Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Images for which previews can't be generated can't be viewed #1282

Closed
icewind1991 opened this issue Jul 8, 2022 · 0 comments · Fixed by #1437
Closed

Images for which previews can't be generated can't be viewed #1282

icewind1991 opened this issue Jul 8, 2022 · 0 comments · Fixed by #1437
Assignees
@skjnldsv
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Milestone
Nextcloud 26

Comments

@icewind1991
Copy link
Member

Describe the bug

Images for which previews can't be generated can't be viewed, it will show an error messages with "Error loading ..." instead

To Reproduce
Steps to reproduce the behavior:

  1. Upload an image file to large to generate a preview for (~6000x6000) or set preview_max_memory to a value lower than the default 128.
  2. Try to view the image

Expected behavior

If a preview can't be generated, the viewer should fallback to loading the original image.
@icewind1991 icewind1991 added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jul 8, 2022
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jul 8, 2022
@jkellerer jkellerer mentioned this issue Oct 25, 2022
Draft
@skjnldsv skjnldsv self-assigned this Oct 25, 2022
@skjnldsv skjnldsv mentioned this issue Oct 26, 2022
Merged
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skjnldsv skjnldsv

Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging a pull request may close this issue.

Fallback to direct image if preview load failed nextcloud/viewer
2 participants
@icewind1991 @skjnldsv