Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty sidebar when viewing photo in Photos #1457

Closed
ollioddi opened this issue Nov 3, 2022 · 8 comments
Closed

Empty sidebar when viewing photo in Photos #1457

ollioddi opened this issue Nov 3, 2022 · 8 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@ollioddi
Copy link

ollioddi commented Nov 3, 2022

Describe the bug
When using the Photos app, there is no sidebar info for pictures.

Seeing the same photo in files, shows sidebar info.

Nextcloud 25.0.0
Photos 2.0.0

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Photos'
  2. Select a photo
  3. Click on 'Open sidebar'
  4. The sidebar is empty / blank.
    image

Expected behavior
Sidebar info showing.
Screenshot from "Files" viewing the same file.
image

Desktop (please complete the following information):

  • OS: Windows 10 Enterprise
  • Browser Latest Edge and Firefox

Browser log

{
    "message": "Request failed with status code 404",
    "name": "AxiosError",
    "config": {
        "transitional": {
            "silentJSONParsing": true,
            "forcedJSONParsing": true,
            "clarifyTimeoutError": false
        },
        "transformRequest": [
            null
        ],
        "transformResponse": [
            null
        ],
        "timeout": 0,
        "xsrfCookieName": "XSRF-TOKEN",
        "xsrfHeaderName": "X-XSRF-TOKEN",
        "maxContentLength": -1,
        "maxBodyLength": -1,
        "env": {
            "FormData": null
        },
        "headers": {
            "Accept": "application/json, text/plain, */*",
            "requesttoken": "TOKEN"
        },
        "method": "propfind",
        "url": "https://ADRESS/remote.php/dav/files/USER/files/USER/Photos/2022/10/20221001_000000_5A1ACB5A.jpg",
        "data": "<?xml version=\"1.0\"?>\n\t\t\t<d:propfind  xmlns:d=\"DAV:\"\n\t\t\t\txmlns:oc=\"http://owncloud.org/ns\"\n\t\t\t\txmlns:nc=\"http://nextcloud.org/ns\"\n\t\t\t\txmlns:ocs=\"http://open-collaboration-services.org/ns\">\n\t\t\t<d:prop>\n\t\t\t\t<d:getlastmodified />\n\t\t\t\t<d:getetag />\n\t\t\t\t<d:getcontenttype />\n\t\t\t\t<d:resourcetype />\n\t\t\t\t<oc:fileid />\n\t\t\t\t<oc:permissions />\n\t\t\t\t<oc:size />\n\t\t\t\t<d:getcontentlength />\n\t\t\t\t<nc:has-preview />\n\t\t\t\t<nc:mount-type />\n\t\t\t\t<nc:is-encrypted />\n\t\t\t\t<ocs:share-permissions />\n\t\t\t\t<nc:share-attributes />\n\t\t\t\t<oc:tags />\n\t\t\t\t<oc:favorite />\n\t\t\t\t<oc:comments-unread />\n\t\t\t\t<oc:owner-id />\n\t\t\t\t<oc:owner-display-name />\n\t\t\t\t<oc:share-types />\n\t\t\t</d:prop>\n\t\t\t</d:propfind>"
    },
    "code": "ERR_BAD_REQUEST",
    "status": 404
}

vue.runtime.esm.js:3019 
        
Error: AxiosError: Request failed with status code 404
    at Sidebar.vue:441:1
    at u (runtime.js:63:40)
    at Generator._invoke (runtime.js:294:22)
    at Generator.throw (runtime.js:119:21)
    at E (LegacyView.vue?a2e2:19:33)
    at a (LegacyView.vue?a2e2:19:33)

Additional context
Let me know if this issue is in the wrong repo. Seems like a "Sidebar" issue, but it only occurs in Photos.

@ollioddi ollioddi added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Nov 3, 2022
@hansixxxx
Copy link

Same problem for me

@darguez
Copy link

darguez commented Nov 3, 2022

Same problem here since 25.0.0

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2022

Can you try again with 25.0.1?

@szaimen szaimen added the needs info Not enough information provided label Nov 10, 2022
@ollioddi
Copy link
Author

ollioddi commented Nov 10, 2022

@szaimen The issue seems to be resolved in 25.0.1 and i am able to view sidebar from Photos.

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2022

Great!

@szaimen szaimen closed this as completed Nov 10, 2022
@bonswouar
Copy link

@szaimen That might need to be reopened?

Not sure if that's exactly the same issue (and if that's a photos or server's issue), but since I've updated from NC 24 to NC 25.0.1 the sidebar doesn't work in Photos app.. but only for some paths apparently!

For example here is the error returned by the PROFIND call on /remote.php/dav/files/bonswouar/Photos/Google%25C2%25A0Photos/Photos%2520from%25202015/IMG_1111.jpg

<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:exception>Sabre\DAV\Exception\NotFound</s:exception>
  <s:message>File with name /Photos/Google%C2%A0Photos could not be located</s:message>
</d:error>

Although I can download the file! (so not directly related to #2389 even if that looks similar)

Weirdly it seems to work correctly for paths not containing a /Photos */ subdirectory. For example /remote.php/dav/files/bonswouar/Photos/InstantUpload/Camera/IMG_1111.jpg does work.

Looks like there's something wrong with standard spaces somewhere? 🤔

@szaimen szaimen reopened this Nov 10, 2022
@szaimen szaimen transferred this issue from nextcloud/photos Nov 10, 2022
@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2022

cc @skjnldsv @artonge

@szaimen szaimen removed the needs info Not enough information provided label Nov 10, 2022
@skjnldsv
Copy link
Member

Fixed, see nextcloud/photos#1465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants