Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full screenview and fullscreen. #21

Closed
matiasdelellis opened this issue Mar 7, 2019 · 5 comments · Fixed by #47
Closed

Full screenview and fullscreen. #21

matiasdelellis opened this issue Mar 7, 2019 · 5 comments · Fixed by #47
Labels
2. developing Work in progress enhancement New feature or request

Comments

@matiasdelellis
Copy link

matiasdelellis commented Mar 7, 2019

Thanks for the application.. :
At some point I tried to do something similar with lightgallery.js.. 😅
..and although I can request many features, this seems to me the most basic.. 😉

zoom feature

  • If I am visualizing photos, with full quality, I want to be able to enlarge the image to see the details..
  • NOTE: I saw a discussion about using thumbnails or not in another issue. I also think that we have to use the originals, mostly due of this point that I propose, but would be nice to download a small thumbnail, to show background while loading the original.

Full viewscreen

  • e.g.: If the idea is to expand the functionality, to visualize any content, I am tempted to write a plugin, to view the pdf, but to be useful, it must expand to occupy the entire viewport.

Full screen.

  • If there is a button to play the photos and videos in sequence, why not do it in full screen. ?

Thanks again, 😄

@skjnldsv skjnldsv added enhancement New feature or request 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Mar 7, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Mar 8, 2019

Hello! Thanks for passing by!! :D
Great suggestions, zooming is actually planned soon! Here is my work so far : #23

Let's focus on the fullscreen on this issue then 😉

I'm not sure about having two supports on fullscreen and viewscreen. They seem to verlap a bit, maybe fullscreen only? @jancborchardt ?

@skjnldsv skjnldsv changed the title Feature request: Zoom, Full screenview, and fullscreen. Feature request: Full screenview and fullscreen. Mar 8, 2019
@jancborchardt
Copy link
Member

Currently the pictures are much too small. By default, the pictures should be displayed much larger than they are now. :) Like 90% of height, only with space for the name at the top and a bit of whitespace at the bottom too.

@skjnldsv
Copy link
Member

Now that this is bigger, what do we do woth this issue @jancborchardt ? :)
Is a full-screen mode something you think might be interesting?

@jancborchardt
Copy link
Member

Maybe what we can do that if the window is fullscreened, we show the images absolutely filling the view, and completely black background (basically like we do on mobile)?

We can separately decide if we e.g. want a fullscreen button in the header.

@skjnldsv
Copy link
Member

@jancborchardt seems like a good idea!

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of 2. developing Work in progress and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. 1. to develop Accepted and waiting to be taken care of labels Mar 16, 2019
@skjnldsv skjnldsv changed the title Feature request: Full screenview and fullscreen. Full screenview and fullscreen. Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants