Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow viewer not adapting sorting mode of files app #366

Open
stephanhoennekes opened this issue Jan 21, 2020 · 19 comments
Open

Slideshow viewer not adapting sorting mode of files app #366

stephanhoennekes opened this issue Jan 21, 2020 · 19 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@stephanhoennekes
Copy link

Actual behavior:
If the slideshow viewer is opened from the files app, its always using standard ascending/alphabetical order by file name (when clicking the arrows).

Expected behavior:
If a descending order by name or any order by file date or file size is chosen in the files app, the slideshow viewer should adopt this behavior by clicking the arrows as it was the case with the old gallery app.

@stephanhoennekes stephanhoennekes changed the title Slideshow viewer not adapting order mode of files app Slideshow viewer not adapting sorting mode of files app Jan 21, 2020
@skjnldsv

This comment has been minimized.

@stephanhoennekes

This comment has been minimized.

@skjnldsv skjnldsv transferred this issue from nextcloud/photos Jan 22, 2020
@skjnldsv

This comment has been minimized.

@jakobroehrl
Copy link
Contributor

@skjnldsv
How to fix this?
Does https://github.com/nextcloud/viewer/blob/master/src/services/FileList.js needs an sort parameter?

@skjnldsv
Copy link
Member

@jakobroehrl

const sortCompare = function(fileInfo1, fileInfo2, key, asc = true) {

viewer/src/views/Viewer.vue

Lines 375 to 378 in 4280f99

// sort like the files list
// TODO: implement global sorting API
// https://github.com/nextcloud/server/blob/a83b79c5f8ab20ed9b4d751167417a65fa3c42b8/apps/files/lib/Controller/ApiController.php#L247
this.fileList = filteredFiles.sort((a, b) => sortCompare(a, b, 'basename'))

@jakobroehrl jakobroehrl self-assigned this Sep 30, 2020
@jakobroehrl
Copy link
Contributor

Thanks @skjnldsv
But how can I query the users sort criteria (by name, size or modified) from files app?

@skjnldsv
Copy link
Member

skjnldsv commented Oct 6, 2020

This is unfortunately not implemented yet.
Ideally this should be a proper standard API :/

@jakobroehrl
Copy link
Contributor

So then I can't solve this Issue, right?

@valdearg
Copy link

Did we ever get any further with this issue? It's frankly insane that after two years we still can't view images in order.

Is there anything we can do to get this put on some priority list?

@cmprmsd
Copy link

cmprmsd commented Aug 13, 2022

Since this issue might take another 10 years of resolving if there are central api changes needed, might it be possible to at least fix the natural sorting of images manually?

Having files behaving differently in the file viewer and slideshow is a no brainer especially on the mobile website.

I'm referring to the wrong sorting of
1
10
100
2
20
200
3
...
in the slideshow whereas the file viewer sorts correctly.

@johnnyq
Copy link

johnnyq commented Sep 2, 2022

Yes this is completely frustrating and should be way up there on the priority list, although it may not be as easy to fix as one would think

@TheAnachronism
Copy link

Yes this is completely frustrating and should be way up there on the priority list
Agree, basically makes the entire image display functionality for me useless because I can't just rename around 10k images so they have a name, for Nextcloud to correctly order them.

Why isn't there more discussion or attention on this??

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Jan 15, 2023
@Jerome-Herbinet
Copy link
Member

Hello,

In my humble opinion, this functional bug should be fixed as a matter of urgency because since the acceleration and highlighting of Nextcloud Photos "2.0" and especially of the "viewer" which now incorporates a retouching tool, this will lead to a lot of disappointments (too bad for a "basic" function).

I hope you don't see any aggression in my comment, because I know you have a lot of other things to think about 😉, but I always imagine that when developing software it is wiser to consolidate the basic functionality before adding new features.

@TommySchwartz
Copy link

TommySchwartz commented Feb 1, 2024

Is this the main and officially thread for adding a fix-this vote for the sorting disorder?
Found I don't know how many threads about this problem but most of them pointed here, and this issue is still open.

For me I don't care about exif sorting for now, I just want the sorting to be as shown in the actual folder, name, size or last changed.

Otherwise really thankful about nextcloud, its the perfect software in this tech dystopian times.

@marco-calautti
Copy link

This issue is still present in the latest stable version of Nextcloud. It has been 3 years now. Are there any plans to fix this?

@cmprmsd
Copy link

cmprmsd commented Feb 17, 2024

No plans :D

@marco-calautti
Copy link

No plans :D

That's something I would like to hear from the developers.

@cmprmsd
Copy link

cmprmsd commented Feb 17, 2024

Look at the close comments on some of the other issues.

skjnldsv closed this as not planned on Sep 8, 2022

Sad reality.

@johnnyq
Copy link

johnnyq commented Feb 17, 2024

@cmprmsd I think this will be fixed sooner now since Nextcloud Files 28.0 adopted the newer backend libraries, so it would make sense to fix it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants