Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video doesn't scale in fullscreen #994

Closed
Axel186 opened this issue Aug 22, 2021 · 3 comments
Closed

Video doesn't scale in fullscreen #994

Axel186 opened this issue Aug 22, 2021 · 3 comments
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@Axel186
Copy link

Axel186 commented Aug 22, 2021

Describe the bug
In fullscreen mode, video doesn't scale across the whole display.

To Reproduce
Steps to reproduce the behavior:

  1. Click the fullscreen icon
  2. Observe the error

Expected behavior
In fullscreen mode, video scales across the whole display.

Temporary Solution that I used
I added the next CSS rule, but this might break other logic:

.plyr:-webkit-full-screen video {
    height: 100% !important;
    width: 100% !important;
}

Screenshots
screenshot

Desktop (please complete the following information):

  • OS: MacOS (Big Sur)
  • Browser Chrome Version 92.0.4515.159
  • Nextcloud 21.0.4

Browser log

No errors in console.

Additional context
The original issue that was opened on deprecated repo: nextcloud/files_videoplayer#77

@Axel186 Axel186 added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Aug 22, 2021
@citronalco
Copy link

Seems like the fullscreen function works only in some(!) versions of Chrome/Chromium, but not in Firefox or Safari. There are several bug reports about this (#1037, or in the old repo: nextcloud/files_videoplayer#224).

Interestingly it works properly with every browser everywhere when using the browsers' fullscreen function (holding shift to disable the blocking of the context menu #678, right mouse click, select "Play in Fullscreen")

@ChildLearningClub
Copy link

ChildLearningClub commented Oct 16, 2022

On ios Safari I only have the issue of videos not scaling properly when I have a shared folder with more then one item. When it is a single shared video file it plays with the ios native built in player and works perfectly. It seems to be an issue with the way that videos are played when in a set. Is there no way for the videos played in a set to inherit the same player/css or whatever it is that is used to play single shared videos? This is a pretty old issue. I hope it's fixed in Hub 3 / Nextcloud 25 :)

@skjnldsv
Copy link
Member

skjnldsv commented Oct 16, 2022

Yep, can't reproduce in 25 with chromium, brave or ff.
For iOS, see #1037

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants