vhost needs to be changed when upgrading to v14

[thibaultmol]

Steps to reproduce

1. Install V13
2. Update to V14

Behaviour

When going to the /settings/admin/overview page, it says the following after the upgrade:

There are some warnings regarding your setup.
The "Referrer-Policy" HTTP header is not set to "no-referrer", "no-referrer-when-downgrade", "strict-origin" or "strict-origin-when-cross-origin". This can leak referer information. See the W3C Recommendation ↗.

How did you install the VM? Installed from Master and then updated using the script (update was successful it said)

Network

Do you use DHCP? Digitalocean VPS

Is port 80 and/or 443 open? yes

So just seems like this config change needs to happen when updating: nextcloud/server#10624 (comment)

[enoch85]

@thibaultmol Thanks, that's actually known but I haven't had the time to fix it yet.

It's pretty easy actually. In the vhost config file just add this to you config and the issue is solved.

[enoch85]

@thibaultmol Actually, it was pretty simple when I thought of it.

Please test #664 by removing the value then run the update script again from the PR.

[thibaultmol]

@enoch85 I can't seem to get it working.

What I did (on the Digitalocean droplet I have encountered this problem) was :
wget https://raw.githubusercontent.com/nextcloud/vm/header/nextcloud_update.sh
opened it via nano to delete the version checking 'exit 1' line. Because otherwise it wouldn't run the script since I'm already on v14 there. (and checked that I indeed had the correct file (I could see the lines added from those commits in the file).
run it with 'sudo bash nextcloud_update.sh'
rebooted
But it's still giving me that error (can't seem to see the line being added to any of the files in /etc/apache2/sites-available/

[enoch85]

What's the name of your vhost in apache?

It only checks for subdomain,yourdomain.xyz which is the case if you run the LE script.

[thibaultmol]

@enoch85
(also, I seem to be getting an error in the nextcloud logs every few minutes. But don't think it's relevant to this, but just in case: Module 'redis' already loaded at Unknown#0 )

[enoch85]

(also, I seem to be getting an error in the nextcloud logs every few minutes. But don't think it's relevant to this, but just in case: Module 'redis' already loaded at Unknown#0 )

Can you please report another issue for that?

What's the output of hostname -f?

[thibaultmol]

@enoch85 nextcloud.thibaultmol.link

[enoch85]

I tested it and it works, so I merged it now. Please remove the line in your apache config and then run update.sh as usual.

[thibaultmol]

@enoch85 I don't see the line though. What line are you referring to? (or are you referring to the file itself?)

[enoch85]

@thibaultmol Do you have Teamviewer?

Please send me an email and I'll do it for you. :)

[thibaultmol]

@enoch85 sent it to github AT hanssonit.se

[enoch85]

Thanks, issue solved. :)

[avalx]

@thibaultmol Thanks, that's actually known but I haven't had the time to fix it yet.

It's pretty easy actually. In the vhost config file just add this to you config and the issue is solved.

I've just upgraded from 14.0.3 to 14.0.4 and now I get this warning message - it was not present in 14.0.3! I tried the change you suggest (in my /etc/httpd/conf.d/nextcloud.conf file) but I still get this warning.

Do I have to do something else to resolve this?

[enoch85]

I think this is the PR that is causing this behavior.

[enoch85]

Or this one

[enoch85]

But still strange since we use the correct Policy:

Code allows
https://github.com/nextcloud/server/pull/11950/files#diff-29fe36c19faa810480111c351a2d276dL457
We set
https://github.com/nextcloud/vm/blob/master/nextcloud_install_production.sh
https://github.com/nextcloud/vm/blob/master/lets-encrypt/activate-ssl.sh#L138

[avalx]

So there is nothing I need to do at the moment?

[enoch85]

I will have a look at this later this weekend.

[enoch85]

Just found out that removing it from the Apache vhost fixed the issue.

cc @rullzer @MorrisJobke So that PR when it was added to .htaccess it acutally borke the setup check.

[avalx]

Great, thank you!