Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add glob() method for globs in favor of file() #3109

Closed
bentsherman opened this issue Aug 10, 2022 · 4 comments · Fixed by #3123
Closed

Add glob() method for globs in favor of file() #3109

bentsherman opened this issue Aug 10, 2022 · 4 comments · Fixed by #3123
Assignees
Labels

Comments

@bentsherman
Copy link
Member

Spawned from the language improvements mega-discussion (#3107). The file() method can be used to load a single file or multiple files using a glob string, which means this function can return a single path or a list depending on the input. This is bad. See #1236 and #2425 for similar problems.

Instead, there should be a separate function for globs, e.g. glob(), and the glob support via file() should be deprecated.

@pditommaso
Copy link
Member

@bentsherman
Copy link
Member Author

If it's not in the docs then it doesn't exist!

@bentsherman
Copy link
Member Author

Are you okay if we rearrange these functions so that file() throws a deprecation warning if you give it a glob?

@pditommaso
Copy link
Member

It's a -1, this would mess up hundreds of pipelines for a problem can be solved just properly document file and files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants