Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Reminder for global data pruner setting #6271

Open
charichu opened this issue Jul 31, 2024 · 5 comments
Open

[IDEA] Reminder for global data pruner setting #6271

charichu opened this issue Jul 31, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@charichu
Copy link

Is your feature request related to a problem? Please describe.
When you move around between many mirth installations, it can happen, that you do not enable the data pruner globally, but that you configure the data pruning within channels.
Plenty of engineers have assumed that because they set the data pruner in a channels summary tab, they were all set. This can become a problem quickly when a typical workflow is copying an existing interface without making changes to the previous channel’s settings.

Describe your use case
This feature would assist engineers to not forget the global setting.

Describe the solution you'd like
There should be a notification within the channel summary tab, if the data pruner is disabled globally. So the engineer gets a reminder.

Describe alternatives you've considered
A pop up, while saving changes on the data pruner, that these changes wont have any effect until it is enabled globally, or disabled the whole data pruner section in the summary tab, to show if it is disabled.

@charichu charichu added the enhancement New feature or request label Jul 31, 2024
@charichu charichu changed the title [IDEA] Your Issue Title [IDEA] Reminder for global data pruner setting Jul 31, 2024
@pacmano1
Copy link
Collaborator

That seems like a checklist item to me as part of your QA proces, not something that requires a user interface reminder. The main problem to me is that it is an arbitrary reminder in the sense of "how many things should we remind the user to do because perhaps they don't have a good QA/PROD/DEV process?"

@jonbartels
Copy link
Contributor

Workaround

A workaround are queries like this - https://gist.github.com/MichaelLeeHobbs/67980d165fc68880eb2ab283c673244b

Several users in the community use this query (or one like it) to generate a report about the Mirth pruner settings both globally and for each channel.

I have this query set up so that Mirth runs the query, throws an error, and sends an alert if the global pruner is disabled or if any single channel does not adhere to my standards for pruning time ranges.

Possible Solution

What charichu proposes is a good idea. Having a "don't do dumb things" warning is useful in Mirth Connect. The SSL warning screen is one example.

This can be implemented as a client-side plugin. The plugin can generate a popup or a simple warning flag in a menu or status bar.

@charichu
Copy link
Author

charichu commented Aug 6, 2024

Thank you for the example query. I will try this out.

Personally, I dont think a QA checklist is superior to an actual implementation, which helps avoid a thing to actually being considered in a QA checklist, but I do understand that limited resources lead to deprioritizing things like these.

Maybe I will comeback to this soon and create my own PR for this, if that would be ok then?

@pacmano1
Copy link
Collaborator

pacmano1 commented Aug 6, 2024

I wasn't saying the idea is bad per se - but at some point, for any tool we all use, there can be only so many alert warnings before they are an irritation and people just ignore them and/or they become not helpful. I tend to think catastrophic destruction actions need warnings more than a warning that someone forget to turn something on. For example - how does Mirth alert someone that the mirthdb should be backed up? Not possible. And a QA / checklist item.

@jonbartels
Copy link
Contributor

Maybe I will comeback to this soon and create my own PR for this, if that would be ok then?

Mirth is an open-source project. PRs are always appreciated by the community. The project owner, NextGen Healthcare, sometimes takes time to respond to PRs. They do eventually get to them.

I would strongly suggest writing your own implementation as a Mirth plugin. This means you will be able to write only your code relevant for your pruning goals. It also means that you do not have to compile the whole Mirth app, just a plugin. Finally since it is a plugin, anyone can run it on their instances even if your PR is not accepted. Plugins can also be added to the core product if NextGen wants to.

This guide: https://github.com/kpalang/mirth-plugin-guide is a good review of plugins. If you start a fork or a project, please post a link and the community can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants