Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Modal split into client/server error #1296

Closed
Fami6Xx opened this issue Aug 6, 2023 · 2 comments
Closed

[BUG] - Modal split into client/server error #1296

Fami6Xx opened this issue Aug 6, 2023 · 2 comments
Labels
🐛 Type: Bug Something isn't working

Comments

@Fami6Xx
Copy link

Fami6Xx commented Aug 6, 2023

Describe the bug

It is because the modal has these two export * from "..."

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

  1. Create a new project
  2. Create 2 files (ModalClient, ModalServer)
  3. In ModalClient, create just a button and Modal and into modal put {props.children} so that everything else can be server
  4. In ModalServer write everything else that is needed in modal (This has to be Server component)
  5. In page.js just put ModalClient and into it ModalServer
  6. Build

Expected behavior

The modal component can be split into client / server components

Screenshots or Videos

image

Server component

Client component (NavbarNextButton)

Server component (NavbarNextModal)

Operating System Version

Windows 10

Browser

Other (add additonal context)

@Fami6Xx Fami6Xx added the 🐛 Type: Bug Something isn't working label Aug 6, 2023
@jrgarciadev
Copy link
Member

jrgarciadev commented Aug 6, 2023

Hey @Fami6Xx please try this with the latest version, yesterday I changed all exports to named exports

#1291

@Fami6Xx
Copy link
Author

Fami6Xx commented Aug 6, 2023

Seems to be working now, thanks for fast fix

@Fami6Xx Fami6Xx closed this as completed Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants