[BUG] - Dropdown closes on scroll even with shouldCloseOnScroll: false

[AnYiEE]

NextUI Version

2.6.7/2.6.8

Describe the bug

Upgrading from 2.6.5 to the above two versions, when setting shouldBlockScroll to false, the Dropdown will close when scrolling, even if shouldCloseOnScroll is set to false.

Your Example Website or App

No response

Steps to Reproduce the Bug or Issue

Set shouldBlockScroll to false, set shouldCloseOnScroll to false.

Expected behavior

The Dropdown will not be closed when scrolling.

Screenshots or Videos

No response

Operating System Version

Windows

Browser

Chrome

[linear]

ENG-1706 [BUG] - After upgrading from 2.6.5 to 2.6.7, the `Dropdown` is always closed when scrolling

[wingkwong]

seems introduced from #4288

[AnYiEE]

For #4251 and #4290, I still think they are the same issue, as they are both Popover-based components, and fixing only #4288 is not comprehensive.

[AnYiEE]

@wingkwong When I tried to reproduce it on the document page, I saw that https://nextui.org/docs/components/dropdown#dropdown-props listed PopoverProps. I remember it wasn't like this before, and the Dropdown component actually doesn't have a prop named PopoverProps. There are also no related controls in the storybook at https://storybook.nextui.org/?path=/story/components-dropdown--default

[wingkwong]

I remember it wasn't like this before, and the Dropdown component actually doesn't have a prop named PopoverProps.

There is no such prop called PopoverProps. If you look at the note,

Since the dropdown is an extension of the popover, it accepts all the props of the popover component

What it means is you can use those props from PopoverProps, which are listed in https://nextui.org/docs/components/popover#popover-props

[AnYiEE]

What it means is you can use those props from PopoverProps, which are listed in https://nextui.org/docs/components/popover#popover-props

But the Dropdown storybook is missing popover related props too, no options to control when previewing.

[ryo-manba]

It seems that this issue already occurs with @nextui-org/react: "2.4.8".
It is not a problem introduced after version 2.6.5.
See: https://stackblitz.com/edit/vitejs-vite-2xwku3js?file=package.json

[ryo-manba]

Please create a separate issue for problems that are not related to this one.

[AnYiEE]

I'm using 2.6.5, it's work. https://github.com/AnYiEE/touhou-mystia-izakaya-assistant/blob/master/package.json#L78

[ryo-manba]

That's a strange. I tried it with 2.6.5, but it doesn't work.
See: https://stackblitz.com/edit/vitejs-vite-uheqs3du?file=src%2FApp.tsx

Could you create a minimal reproduction? It would help us resolve the issue faster.