Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create_release_notes.py should use SHA credentials #729

Closed
PeterC-DLS opened this issue Jan 23, 2020 · 1 comment · Fixed by #735
Closed

create_release_notes.py should use SHA credentials #729

PeterC-DLS opened this issue Jan 23, 2020 · 1 comment · Fixed by #735
Assignees
@prjemian
Labels
implementation task
Milestone
NXDL 2020.1

Comments

@PeterC-DLS
Copy link
Contributor

Remove need to have separate file to store credentials
@prjemian prjemian self-assigned this Jan 26, 2020
@prjemian prjemian added this to the NXDL 2020.1 milestone Jan 26, 2020
@prjemian
Copy link
Contributor

As part of #728, will switch credentialing to use GitHub's Personal Access Token credentialing. Use of PAT is preferred over SSH key due to the GitHub API Rate Limit. SSH access is for normal push/pull usage, PAT is used with the GH API.

@prjemian prjemian mentioned this issue Jan 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prjemian prjemian

Labels
implementation task
Projects
None yet
Milestone
NXDL 2020.1
Development

Successfully merging a pull request may close this issue.

Revise release note scripting nexusformat/definitions
2 participants
@PeterC-DLS @prjemian