Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/binsizes #11

Closed
wants to merge 7 commits into from
Closed

Patch/binsizes #11

wants to merge 7 commits into from

Conversation

nvnieuwk
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Sep 22, 2023 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 8bd767c

+| ✅ 128 tests passed       |+
#| ❔  19 tests were ignored |#
!| ❗   2 tests had warnings |!
-| ❌   3 tests failed       |-

❌ Test failures:

  • files_exist - File must be removed: pipeline_template.yml
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • files_unchanged - lib/NfcoreTemplate.groovy does not match the template

❗ Test warnings:

  • schema_description - No description provided in schema for parameter: bin_sizes
  • schema_description - No description provided in schema for parameter: validationSchemaIgnoreParams

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-nf-cmgg-wisecondorx_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-nf-cmgg-wisecondorx_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-nf-cmgg-wisecondorx_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: lib/WorkflowNf-cmgg-wisecondorx.groovy
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File does not exist: assets/nf-core-nf-cmgg-wisecondorx_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-nf-cmgg-wisecondorx_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-nf-cmgg-wisecondorx_logo_dark.png
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/nf-cmgg-wisecondorx/nf-cmgg-wisecondorx/.github/workflows/awstest.yml
  • pipeline_name_conventions - pipeline_name_conventions
  • schema_params - schema_params

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-09-25 15:04:39

@mvheetve
Copy link
Collaborator

is this up for review? Or not yet?

@nvnieuwk
Copy link
Member Author

I completely forgot about this! I'll implement the necessary features from this in #14 😁

@nvnieuwk nvnieuwk closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvnieuwk @mvheetve