Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to 2.2.0dev #102

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Bump to 2.2.0dev #102

merged 3 commits into from
Jan 10, 2024

Conversation

LaurenceKuhl
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/crisprseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 18, 2023 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit 6c340f2

+| ✅ 158 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!
-| ❌   4 tests failed       |-

❌ Test failures:

  • files_unchanged - .github/CONTRIBUTING.md does not match the template
  • files_unchanged - .github/PULL_REQUEST_TEMPLATE.md does not match the template
  • files_unchanged - .github/workflows/linting.yml does not match the template
  • multiqc_config - 'assets/multiqc_config.yml' does not contain a matching 'report_comment'.
    The expected comment is:
    This report has been generated by the <a href="https://github.com/nf-core/crisprseq/tree/dev" target="_blank">nf-core/crisprseq</a> analysis pipeline. For information about how to interpret these results, please see the <a href="https://nf-co.re/crisprseq/dev/docs/output" target="_blank">documentation</a>.
    The current comment is:
    This report has been generated by the <a href="https://github.com/nf-core/crisprseq/releases/tag/dev" target="_blank">nf-core/crisprseq</a> analysis pipeline. For information about how to interpret these results, please see the <a href="https://nf-co.re/crisprseq/dev/docs/output" target="_blank">documentation</a>.

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowCrisprseq.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.11.1
  • Run at 2024-01-10 08:36:16

@mirpedrol
Copy link
Member

@nf-core-bot fix linting

@mirpedrol mirpedrol changed the title New dev Bump to 2.2.0dev Jan 10, 2024
@mirpedrol
Copy link
Member

nf-core linting will be merged with the template update in #105

@mirpedrol mirpedrol merged commit fca2d35 into nf-core:dev Jan 10, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LaurenceKuhl @mirpedrol @nf-core-bot