Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain read group information in bam merging steps #808

Closed
TCLamnidis opened this issue Nov 18, 2021 · 0 comments · Fixed by #809
Closed

Retain read group information in bam merging steps #808

TCLamnidis opened this issue Nov 18, 2021 · 0 comments · Fixed by #809
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@TCLamnidis
Copy link
Collaborator

Is your feature request related to a problem? Please describe

Currently, every bam merging step in nf-core eager will overwrite the read groups in the bam, thus discarding potentially useful information that would otherwise allow users to trace the origin of specific reads to a library/sequencing run. In some form this information may exist among the intermediate files, but it should not be discarded without cause.

This information can be important also for calling of genotype likelihoods (which is currently not done within eager, but might be a good future addition).

Describe the solution you'd like

Each bam merging step should return the union of read groups, instead of overwriting that information.

Additional context

The current behaviour is (I think) a fossil-feature leftover from EAGER, that had to do with how pathogen screening works and how GATK UG prefers its input bams.

I think tweaking the read groups produced during mapping would potentially kill two birds with one stone. Investigating this further.

@TCLamnidis TCLamnidis added bug Something isn't working enhancement New feature or request labels Nov 18, 2021
@TCLamnidis TCLamnidis mentioned this issue Nov 18, 2021
7 tasks
@TCLamnidis TCLamnidis linked a pull request Nov 18, 2021 that will close this issue
7 tasks
@jfy133 jfy133 closed this as completed Nov 24, 2021
@jfy133 jfy133 added this to the 2.5 "Augsburg" milestone Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants