Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nf-test wishlist #398

Open
5 tasks
jasmezz opened this issue Jul 8, 2024 · 0 comments
Open
5 tasks

nf-test wishlist #398

jasmezz opened this issue Jul 8, 2024 · 0 comments
Labels
enhancement Improvement for existing functionality

Comments

@jasmezz
Copy link
Collaborator

jasmezz commented Jul 8, 2024

nf-test wishlist

  • have at least one test profile for prodigal:
    At the moment, we don't test if prodigal actually works, because its wrapper tool pyrodigal is super similar. However, it would be good to have at least 1 test profile with prodigal (e.g. can replace pyrodigal in one of the existing profiles).
  • assertion for zipped files:
    add better assertions for zipped files than just checking for existence (see here).
  • For each of the 3 screening workflows: Make sure that test samplesheets actually produce hits. Currently, BGC workflow has no hits for samplesheet_reduced.csv (only samplesheet_full.csv which is used only by the full test). Some ARG tools have no hits as well.
  • Move external links from test configs to nf-core test-datasets (e.g. antiSMASH: 'https://raw.githubusercontent.com/antismash/antismash/fd61de057e082fbf071732ac64b8b2e8883de32f/antismash/detection/hmm_detection/data/ToyB.hmm')
  • Streamline nf-test files: have a single snapshot for each tool output including exists() and contains() statements (like here for ampir)
@jasmezz jasmezz added the enhancement Improvement for existing functionality label Jul 8, 2024
@jasmezz jasmezz added this to the 2.1 - Egyptian Koshari milestone Jul 8, 2024
@jasmezz jasmezz changed the title Have at least one test profile for prodigal nf-test wishlist Jul 8, 2024
@jasmezz jasmezz mentioned this issue Jul 8, 2024
10 tasks
@jasmezz jasmezz mentioned this issue Aug 9, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant