Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Mad-max filter #193

Closed
jeff-godwin opened this issue Feb 27, 2024 · 1 comment
Closed

[Question] Mad-max filter #193

jeff-godwin opened this issue Feb 27, 2024 · 1 comment

Comments

@jeff-godwin
Copy link

Hello,

I have a question regarding the filtering of low count bins.

The nextflow (v2.1.0) results produces balanced cooler files. Am I correct to assume this is from the "cooler balance" functionality? And is the --mad-max parameter running on the default value of 5 (https://cooler.readthedocs.io/en/latest/cli.html#cooler-balance) ?
In HiCexplorer, one can calculate the mad-max filter using (https://hicexplorer.readthedocs.io/en/latest/content/tools/hicCorrectMatrix.html). Over here, open2c/cooler#140, it is mentioned that both filtering are equivalent. I want to clarify if the balance cool file needs any further filtering?

Many thanks,
Jeffrey

@nservant
Copy link
Collaborator

Hi @jeff-godwin

Until now, we were not changing the default parameter from cooler balance. So the --mad-max option was set by default.
However, I just added a new option --balancing_optswhich allow you to tune the balancing options when running the pipeline.
The new option has been added to the devbranch, and should hopefully be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants