Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Important! Template update for nf-core/tools v2.14.1 #200

Merged
merged 3 commits into from
Jul 11, 2024
Merged

Important! Template update for nf-core/tools v2.14.1 #200

merged 3 commits into from
Jul 11, 2024

Conversation

nf-core-bot
Copy link
Member

Version 2.14.1 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-2.14.1 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v2.14.1 release page.

@nf-core-bot nf-core-bot mentioned this pull request May 9, 2024
Closed
nservant
nservant approved these changes Jul 11, 2024
View reviewed changes
Copy link
Collaborator

@nservant nservant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me

@maxulysse
Copy link
Member

@nservant Solved the merged conflicts hopefully

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 11, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 0ac7114

+| ✅ 229 tests passed       |+
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-07-11 16:10:52

@nservant
Copy link
Collaborator

@maxulysse, I saw some changes in the way the test profiles are now called. So far, I kept the previous settings, but if you have any info/docs on that part, I'll update them. I would like to release a new stable release in the next 2 weeks

@maxulysse
Copy link
Member

@maxulysse, I saw some changes in the way the test profiles are now called. So far, I kept the previous settings, but if you have any info/docs on that part, I'll update them. I would like to release a new stable release in the next 2 weeks

Not really a need to change that actually, since your test samplesheet are in the pipeline and not in a branch, you don't need to change a thing

@nservant nservant merged commit e811df3 into dev Jul 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nservant nservant nservant approved these changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nf-core-bot @maxulysse @nservant