Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not define "NULL" string as a default value at nextflow_schema.json #40

Closed
jordeu opened this issue Jun 16, 2021 · 1 comment
Closed
Labels
enhancement Improvement for existing functionality

Comments

@jordeu
Copy link

jordeu commented Jun 16, 2021

Description

Some fields at nextflow_schema.json file define default values like an string ("default": "NULL") this will be a problem in the upcoming version of tower.nf. The "NULL" string will be set at the launchpad form and send to Nextflow when launching the pipeline. Finally the run will fail because Nextflow will interpret it as a string and not as an empty parameter.

Solution

Aligned with the discussion here about enforcing stricter rules for initialising params with no default value, I suggest to just set this fields to null at nextflow.config file and remove the default setting from the schema file. This will be compatible with the future tower.nf release.

@jordeu jordeu added the enhancement Improvement for existing functionality label Jun 16, 2021
@PayamEmami
Copy link
Contributor

Fixed in the recent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement for existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants